[PRISM] Fix crash when --parser=prism called with stdin #9282
Conversation
|
Thanks for finding this! The fix looks good to me. We could maybe add a test in Are you planning to open a PR to fix the first case as well? I can look, but I don't believe I have any special knowledge here beyond what you have in this PR. |
eightbitraptor
force-pushed
the
mvh-fix-prism-cmdline-segv
branch
from
10a0d7d
to
35dd2ba
Compare
|
This is related to this bug: ruby/prism#1247 |
Thanks! I'll take a look at adding a test to this and then get it shipped As far as a proper fix - I haven't looked into it in major detail yet, but I think that Prism needs to handle this case rather than dealing with it in the options processing code. And I think this issue will need addressed first. |
[Bug #20071] Currently Ruby crashes when the --parser=prism flag is used either with no input, or with input that is being redirected from stdin. So all of the following will crash ruby --parser=prism ruby --parser=prism < test_code.rb cat test_code.rb | ruby --parser=prism This commit checks whether the input is assumed to be from stdin, and then processes that as a file. This will fix the second and third case above, but will cause a slight behavioural changes for the first case - Ruby will treat stdin as an empty file in this case and exit, rather than waiting for data to be piped into stdin.
eightbitraptor
force-pushed
the
mvh-fix-prism-cmdline-segv
branch
from
35dd2ba
to
33e55e4
Compare
Currently Ruby crashes when the --parser=prism flag is used either with no input, or with input that is being redirected from stdin. So all of the following will crash
This commit checks whether the input is assumed to be from stdin, and then processes that as a file.
This will fix the second and third case above, but will cause a slight behavioural changes for the first case - Ruby will treat stdin as an empty file in this case and exit, rather than waiting for data to be piped into stdin.