Test_SyncDefaultGems: Fail when editor run #9365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When something went wrong and git launches editor, and a editor chosen was terminal-based, a test run unnoticeably hangs. As we intend editors not to be run with --no-edit, GIT_EDITOR should be defaulted to `false` so let Git command fails when it attempts to start a editor. This allows catching such unintentional behaviour in test suite. (Note: Prior to Git v2.32.0, git cherry-pick doesn't support --no-edit. git/git@39edfd5 )
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When something went wrong and git launches editor, and a editor chosen was terminal-based, a test run unnoticeably hangs.
As we intend editors not to be ran with --no-edit, GIT_EDITOR should be defaulted to
falseso let Git command fails when it attempts to start a editor. This allows catching such unintentional behaviour in test suite.(Note: Prior to Git v2.32.0, git cherry-pick --no-edit doesn't work for conflict resolution. git/git@39edfd5
i.e. Ubuntu 20.04 focal and Debian Bullseye)