Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues related Encoding with mswin platform #9699

Merged
merged 3 commits into from Jan 25, 2024

Conversation

hsbt
Copy link
Member

@hsbt hsbt commented Jan 25, 2024

Try to fix:

  1) Failure:
Test_String_Fstring#test_rb_enc_interned_str_autoloaded_encoding [C:/Users/hsbt/source/repos/ruby/ruby/test/-ext-/string/test_fstring.rb:18]:
Expected "#<Encoding:Windows-31J>" to include "autoload".

[  7/372] Test_String_Fstring#test_rb_enc_str_new_autoloaded_encoding = 0.26 s
  2) Failure:
Test_String_Fstring#test_rb_enc_str_new_autoloaded_encoding [C:/Users/hsbt/source/repos/ruby/ruby/test/-ext-/string/test_fstring.rb:26]:
Expected "#<Encoding:Windows-31J>" to include "autoload".

[180/372] TestRubyOptions#test_encoding = 0.11 s
  4) Failure:
TestRubyOptions#test_encoding [C:/Users/hsbt/source/repos/ruby/ruby/test/ruby/test_rubyoptions.rb:379]:
pid 16552 exit 1
| -:1: invalid multibyte char (Windows-31J)
| -: compile error (SyntaxError)
.

1. [1/2] Assertion for "stdout"
   | <["あ"]> expected but was
   | <[]>.

2. [2/2] Assertion for "stderr"
   | <[]> expected but was
   | <["-:1: invalid multibyte char (Windows-31J)", "-: compile error (SyntaxError)"]>.

[321/372] TestProcess#test_exec_nonascii = 0.06 s
  5) Failure:
TestProcess#test_exec_nonascii [C:/Users/hsbt/source/repos/ruby/ruby/test/ruby/test_process.rb:2176]:
[ruby-dev:49838] [Bug #12841]
pid 30816 exit 0.

1. [1/2] Assertion for "stdout"
   | <["\x{8D67}\x{8BCA}"]> expected but was
   | <["紅玉"]>.

  Encoding::Windows_31J is already loaded in mswin platform
  In my windows environment uses cp932 for terminal encoding.
  Co-authored-by: Nobuyoshi Nakada <nobu@ruby-lang.org>
@hsbt hsbt merged commit 0f5407b into ruby:master Jan 25, 2024
97 checks passed
@hsbt hsbt deleted the fix-encoding-failure-mswin branch January 25, 2024 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
1 participant