Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

YJIT: Support concattoarray and pushtoarray #9708

Merged
merged 1 commit into from
Jan 25, 2024
Merged

YJIT: Support concattoarray and pushtoarray #9708

merged 1 commit into from
Jan 25, 2024

Conversation

k0kubun
Copy link
Member

@k0kubun k0kubun commented Jan 25, 2024 •
edited
Loading

This PR adds support for concatarray and pushtoarray instructions added in #9247 so that railsbench will not exit on those instructions.

@XrXr
Copy link
Member

XrXr commented Jan 25, 2024 •
edited
Loading

The ARM backtrace is more helpful in case you haven't caught it.

Op::Lea only accepts Opnd::Mem operands.

@k0kubun
Copy link
Member Author

k0kubun commented Jan 25, 2024

Interesting, thanks for the info. I got that from

ruby/yjit/src/codegen.rs

Line 2056 in 2a9635c

let stack_addr_from_top = asm.lea(asm.stack_opnd((num - 1) as i32));
, but maybe that path is unreachable? I'll use sp_offset instead.

@k0kubun k0kubun marked this pull request as ready for review January 25, 2024 21:21
@matzbot matzbot requested a review from a team January 25, 2024 21:21
@maximecb maximecb enabled auto-merge (squash) January 25, 2024 21:37
@maximecb maximecb merged commit 2034e6a into ruby:master Jan 25, 2024
98 checks passed
@k0kubun k0kubun deleted the yjit-toarray branch January 25, 2024 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maximecb maximecb maximecb approved these changes

@XrXr XrXr XrXr approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
3 participants
@k0kubun @XrXr @maximecb