YJIT: Add jit_prepare_call_with_gc function #9775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XrXr
approved these changes
Jan 31, 2024
maximecb
reviewed
Jan 31, 2024
maximecb
reviewed
Jan 31, 2024
maximecb
approved these changes
Jan 31, 2024
Good call 👍 402884d |
k0kubun
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces
jit_prepare_for_gcfunction to dojit_prepare_routine_callwithoutasm.clear_local_types().When a C call may allocate but not call arbitrary methods, we should be able to skip
asm.clear_local_types(). I applied this change to some instructions where I think it makes sense.