Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport #9498 to Ruby 3.3 #9805

Merged
merged 1 commit into from
Mar 14, 2024
Merged

Backport #9498 to Ruby 3.3 #9805

merged 1 commit into from
Mar 14, 2024

Conversation

krk
Copy link
Contributor

@krk krk commented Feb 1, 2024

#9498 fixes a critical bug in low memory environments, backporting to ruby 3.3.

The redblack tree cache is totally optional, so if we can't allocate
room for the cache, then just pretend as if the cache is full if mmap
fails
@hsbt
Copy link
Member

hsbt commented Feb 7, 2024

@krk You should create backport ticket to https://bugs.ruby-lang.org/. see https://github.com/ruby/ruby/wiki/How-To-Request-Backport

@hsbt hsbt added the Backport label Feb 7, 2024
@anton-stepanof
Copy link

@hsbt Ticket https://bugs.ruby-lang.org/issues/20184 with that fix contains Backport 3.3 label. Is it required to create a new ticket?

@hsbt
Copy link
Member

hsbt commented Feb 8, 2024

Is it required to create a new ticket?

No, It's not necessary. It's good to comment this URL to https://bugs.ruby-lang.org/issues/20184

@anton-stepanof
Copy link

anton-stepanof commented Feb 8, 2024

@hsbt ok, I left comment at https://bugs.ruby-lang.org/issues/20184. This ticket is in closed state

@anton-stepanof
Copy link

@hsbt Could you please say if there are plans to include that fix for critical bug to the next release?
My backport pr https://bugs.ruby-lang.org/issues/20263 was closed as duplicate, but the original issue https://bugs.ruby-lang.org/issues/20184 is in closed state.

@nurse nurse added this pull request to the merge queue Mar 14, 2024
Merged via the queue into ruby:ruby_3_3 with commit 53f0c5a Mar 14, 2024
98 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 participants