Do not truncate strings inefficiently #9832
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s7nfo
changed the title
|
I just read ruby/openssl#706 (comment), I think this PR might be moot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey folks,
as I demonstrated in this blog post, truncating string with
s[0, x] = ''seems to lead to unnecessary memory copying. I've identified couple places in Ruby where this pattern is being used and this PR replaces it with the more efficient pattern.If this look like something you might be interested in merging let me know if I need to do anything else here, it's my first PR against Ruby.
Related PR against this same issue in openssl: ruby/openssl#706