-
-
Notifications
You must be signed in to change notification settings - Fork 388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests for Time.at with BigDecimal input #187
Conversation
Therefore I would say move it to |
Let me know if that works for you, however, wouldn't it be better to actually check if require fails and in that case mark the test as skipped? Since in that case it's not a real failure (even if stdlib should be always available) |
@@ -135,4 +135,11 @@ | |||
lambda { Time.at(Time.now, 500000) }.should raise_error(TypeError) | |||
end | |||
end | |||
|
|||
describe "passed BigDecimal" do | |||
require 'bigdecimal' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The require should be in the it
block.
There is a system of tags allowing to skip one example easily so it's not a problem in practice AFAIK. |
Done, let me know if you wanted also the |
Add tests for Time.at with BigDecimal input
It's good as-is, merged, thank you for your contribution! 😃 |
I've added a test that checks if
Time.at
rounds the input when a float BigDecimal is passed.Probably the place of the test is wrong so let me know where it should be moved and I'll be happy to do that.
This relates to jruby/jruby#3616