-
-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Import Socket::Option specs from rubysl-socket #280
Conversation
@etehtsea @yorickpeterse ruby/spec is licensed as MIT, do you agree to re-license those specs with the MIT license? |
@eregon The specs are licensed under the BSD license. Including the BSD license somewhere should suffice. |
This specs are originally authored by @yorickpeterse and licensed by BSD license.
@eregon @yorickpeterse @eregon I added license inside each spec file. |
@etehtsea Thanks for the investigation! |
@eregon good, thanks! |
@yorickpeterse The original socket specs, under the rubyspec project, were not licensed BSD. I believe they were MIT licensed. I know you have added a lot and cleaned up many specs. Did you rewrite all of them from scratch? If you did your additions and modifications atop the older rubyspec code, I have to also ask: did you contact everyone who contributed to those specs and get their permission to relicense as BSD? |
A bit of clarification... I believe MIT is permissive enough that you can add BSD, but I don't think you can remove MIT without getting permission from all former contributors. |
@headius As far as I can remember I re-wrote all specs from scratch. |
This specs are originally authored by @yorickpeterse and licensed by BSD
license.