Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import Socket::Option specs from rubysl-socket #280

Closed
wants to merge 1 commit into from
Closed

Import Socket::Option specs from rubysl-socket #280

wants to merge 1 commit into from

Conversation

etehtsea
Copy link
Contributor

This specs are originally authored by @yorickpeterse and licensed by BSD
license.

@eregon
Copy link
Member

eregon commented Aug 14, 2016

@etehtsea @yorickpeterse ruby/spec is licensed as MIT, do you agree to re-license those specs with the MIT license?

@yorickpeterse
Copy link
Contributor

@eregon The specs are licensed under the BSD license. Including the BSD license somewhere should suffice.

This specs are originally authored by @yorickpeterse and licensed by BSD
license.
@etehtsea
Copy link
Contributor Author

@eregon @yorickpeterse @eregon I added license inside each spec file.

@etehtsea
Copy link
Contributor Author

etehtsea commented Aug 15, 2016

I've found that there was option specs.
cc39ba5
9709120

So another option could be to resurrect them and make uptodate.
Third option is to simply rewrite Socket::Option specs from scratch.

etehtsea added a commit to etehtsea/jruby that referenced this pull request Aug 15, 2016
@eregon
Copy link
Member

eregon commented Aug 15, 2016

@etehtsea Thanks for the investigation!
The license per header seems a good option.
I'll have a look tomorrow, not sure why those specs disappeared since I thought I kept the files removed by that commit, maybe something missed in the merge.

@eregon
Copy link
Member

eregon commented Aug 16, 2016

@etehtsea So indeed a few specs were lost, I added them back in f305537.
The specs look very similar, but it would be good to add the missing parts in the existing ones.
I'll look at that tomorrow.

@etehtsea
Copy link
Contributor Author

@eregon good, thanks!

@etehtsea etehtsea closed this Aug 16, 2016
etehtsea added a commit to etehtsea/jruby that referenced this pull request Aug 19, 2016
@etehtsea etehtsea deleted the import-socket-option branch August 19, 2016 02:43
@headius
Copy link
Contributor

headius commented Aug 19, 2016

@yorickpeterse The original socket specs, under the rubyspec project, were not licensed BSD. I believe they were MIT licensed. I know you have added a lot and cleaned up many specs. Did you rewrite all of them from scratch?

If you did your additions and modifications atop the older rubyspec code, I have to also ask: did you contact everyone who contributed to those specs and get their permission to relicense as BSD?

@headius
Copy link
Contributor

headius commented Aug 19, 2016

A bit of clarification... I believe MIT is permissive enough that you can add BSD, but I don't think you can remove MIT without getting permission from all former contributors.

@yorickpeterse
Copy link
Contributor

@headius As far as I can remember I re-wrote all specs from scratch.

etehtsea added a commit to etehtsea/jruby that referenced this pull request Aug 19, 2016
etehtsea added a commit to etehtsea/jruby that referenced this pull request Aug 20, 2016
etehtsea added a commit to etehtsea/jruby that referenced this pull request Aug 23, 2016
etehtsea added a commit to etehtsea/jruby that referenced this pull request Aug 24, 2016
etehtsea added a commit to etehtsea/jruby that referenced this pull request Sep 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants