Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Socket::Option specs #283

Merged
merged 1 commit into from
Aug 19, 2016
Merged

Improve Socket::Option specs #283

merged 1 commit into from
Aug 19, 2016

Conversation

etehtsea
Copy link
Contributor

  • Cleanup
  • Add bool spec

@etehtsea
Improve Socket::Option specs
17b6275 
- Cleanup
- Add bool spec
@eregon eregon merged commit 62b7184 into ruby:master Aug 19, 2016
@eregon
Copy link
Member

eregon commented Aug 19, 2016

Perfect, thanks!
I think we have about the same coverage as #280 now.

@etehtsea
Copy link
Contributor Author

@eregon yep.

@etehtsea etehtsea deleted the imp-socket-option-spec branch August 19, 2016 08:47
@etehtsea etehtsea mentioned this pull request Aug 19, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@etehtsea @eregon