Adds spec for Feature#17260 and Feature#17231 #855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah, I've noticed that there's range support in the Ruby version blocks. Would that be the recommended way? EDIT - Went ahead and added that in, going to assume so. |
baweaver
force-pushed
the
baweaver/ruby-3/one-line-17260
branch
from
332ea50
to
ae26511
Compare
baweaver
commented
Oct 6, 2021
language/pattern_matching_spec.rb
Outdated
|
|
||
| eval(<<~RUBY).should == false | ||
| [0, 1] in [a, b, c] | ||
| RUBY |
There was a problem hiding this comment.
What are thoughts on this convention of negation? Would prefer to make sure there's a definitive behavior being tested both for and against, as I've been bitten by positive-only tests before.
eregon
reviewed
Oct 6, 2021
|
@baweaver Hello, any chance you could finish this? |
Adds specs for one-line pattern matching syntax in Ruby 3.0+, including both Righthand Assignment (`=>`) and one-line match (`in`).
andrykonchin
force-pushed
the
baweaver/ruby-3/one-line-17260
branch
from
ae26511
to
90ef78c
Compare
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refers to #823
Adds specs for one-line pattern matching syntax in Ruby 3.0+, including
both Righthand Assignment (
=>) and one-line match (in).Notes:
I was confused on how to add specs for only Ruby 2.7 to get
NoMatchingPatternErrorfor0 in 1as the syntax I'd found will run in Ruby 3.0.How exhaustive do we want these tests to be? On one hand they could be reasonably inferred from full pattern matches, and we simply want to check that the syntax works. On the other we should likely test edge-cases.
What are thoughts on this?
I can certainly see a case for a more comprehensive test on possible syntax errors and odd uses to ensure consistency, but want to run that by maintainers first.