Add connect_timeout expect #877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@eregon what do you think? |
JuanCrg90
force-pushed
the
add_connect_timeout_spec
branch
2 times, most recently
from
2733413
to
cabe0d7
Compare
JuanCrg90
force-pushed
the
add_connect_timeout_spec
branch
from
cabe0d7
to
64b787e
Compare
|
🤦🏽 I don't have a windows machine to check what's happening there 🤔 |
* Using a similar approach to the CRuby test TestSocket_TCPSocket#test_initialize_connect_timeout
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From #823
Add :connect_timeout to TCPSocket.new [Feature #17187]