Add new test case for Dir.glob with sort kwarg [Feature #8709] #894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Strech
changed the title
eregon
reviewed
Nov 3, 2021
| result = Dir.send(@method, '*', sort: 0) | ||
| result.should == result.sort | ||
|
|
||
| result = Dir.send(@method, '*', sort: nil) |
There was a problem hiding this comment.
This one feels like a bug worth reporting to https://bugs.ruby-lang.org/projects/ruby-master/issues, could you do that?
nil is normally always considered false or have separate (unique to nil) semantics in Ruby.
There was a problem hiding this comment.
Yes, was a bit confused that nil doesn't change sorting, but at the same time, false feels like the only correct way to say – don't sort it!
Will report and attach the patch file
eregon
approved these changes
Nov 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cover the case when a non
falsevalue is given to theDir.glob. Since we don't have type checks, I think it makes sense to cover that behaviour