Add support of sort argument as nil for Dir.glob #5079
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now `Dir.glob("*", sort: nil)` will produce the same result as
`Dir.glob("*", sort: true)`.
```
irb(main):001:0> Dir.glob("brace/a{.js,*}", sort: true)
=> ["brace/a.js", "brace/a", "brace/a.erb", "brace/a.html.erb", "brace/a.js", "brace/a.js.rjs"]
irb(main):001:0> Dir.glob("brace/a{.js,*}", sort: false)
=> ["brace/a.js", "brace/a.js", "brace/a.html.erb", "brace/a.erb", "brace/a.js.rjs", "brace/a"]
irb(main):001:0> Dir.glob("brace/a{.js,*}", sort: nil)
=> ["brace/a.js", "brace/a", "brace/a.erb", "brace/a.html.erb", "brace/a.js", "brace/a.js.rjs"]
```
After this patch both `Dir.glob("*", sort: false)` and `Dir.glob("*"
sort: nil)` will produce identical unsorted results.
eregon
reviewed
Nov 4, 2021
| @@ -2937,7 +2937,7 @@ dir_glob_option_base(VALUE base) | |||
| static int | |||
| dir_glob_option_sort(VALUE sort) | |||
| { | |||
| return (sort ? 0 : FNM_GLOB_NOSORT); | |||
| return ((NIL_P(sort) || sort == Qfalse) ? FNM_GLOB_NOSORT : 0); | |||
There was a problem hiding this comment.
There is RTEST, so a nicer way here is !RTEST(sort) or better swap the branches so there is no !.
There was a problem hiding this comment.
Thanks for the feedback, will wait a while
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now
Dir.glob("*", sort: nil)will produce the same result asDir.glob("*", sort: true).After this patch both
Dir.glob("*", sort: false)andDir.glob("*" sort: nil)will produce identical unsorted results.Current behaviour was noted here: ruby/spec#894 and @eregon suggested addressing it bugs#18287