-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Eagerly defrost chilled strings #94
Conversation
5796bc4
to
a175c4c
Compare
I updated this to not use I also realized there were warnings in the output, so I added assertions to ensure they're here and to remove them from the test output. |
f4f5f70
to
a175c4c
Compare
CI is still using a ruby-head from a couple days ago: |
I scheduled a new build. The last one failed due to assertion errors (already fixed on master). |
a175c4c
to
e5c832a
Compare
The windows build is still lagging behind by just a handful of commits, but other than that it's now all green. |
8b6697f
to
e6edc8b
Compare
[Bug #20390] Co-authored-by: Jean Boussier <byroot@ruby-lang.org>
e6edc8b
to
7ae21ab
Compare
I think this can be reverted now? ruby/ruby#10849 |
Indeed, I think so and maybe rb_str_chilled_p() can even be removed? |
I don't think so, because of But yeah, I need to look more in details how the last change impact StringIO, we may still want to trigger the warning early to be honest. Not 100% sure. |
[Feature #20205] Followup: ruby#94 They no longer need to be special cases. If StringIO end up mutating a chilled string, a warning will be emitted.
Right, I mean making it non-public API, for example with a |
[Feature #20205] Followup: ruby#94 They no longer need to be special cases. If StringIO end up mutating a chilled string, a warning will be emitted.
[Feature #20205] Followup: #94 They no longer need to be special cases. If StringIO end up mutating a chilled string, a warning will be emitted.
[Feature #20205] Followup: ruby/stringio#94 They no longer need to be special cases. If StringIO end up mutating a chilled string, a warning will be emitted. ruby/stringio@dc62d65449
[Bug #20390]
Depends on ruby/ruby#10355