[close #20] Simplify large file output #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change reduces the output to only the minimal context needed.
Stable sort means that when elements are entered into an array that have the same value, they will be sorted in the same order. For example:
```
MyValue = Struct.new(:value, :name)
[MyValue.new(1, :a), MyValue.new(1, :b), MyValue.new(1, :c)]
.sort_by {|x| x.value }
.map(&:name)
```
You would expect this to always produce `[:a, :b, :c]` since that's the original order that they're entered in, however since ruby's sort is not "stable" this is not the case.
This non-determinism causes tests to produce different results on different systems which leads to CI failures. We can mitigate this by sorting by the value we want first, then by some consistent secondary value. In this case I'm using line number for the first code block.
schneems
force-pushed
the
schneems/better-output-format
branch
from
a4f60c1
to
6717be4
Compare
Previously when we were trying to capture the "neighbors" context, we were using the same logic as when trying to "expand" a block. This logic looks for unmatched keyword pairs, so when it looks up it will stop at `def foo` but not at `def foo; end`. For grabbing context we want to stop after the first contextual pair so we cannot use that same method. Instead a new method that is specialized to finding context is introduced to the AroundBlockScan class. When trying to capture code context, we don't want to look for a dangling keyword, we want the first matched pair
schneems
force-pushed
the
schneems/better-output-format
branch
from
6717be4
to
9036905
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change reduces the output to only the minimal context needed.