Fix verbose compile warnings #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was found via a verbose warning. @tpath would always be nil in the previous code, so attempting to initialize a Tk::TkTable::CellTag should have always raised a NoMethodError.
…for_cb_class If cmd was passed a string, this set an unused local variable, when the apparent intent was to set an instance variable. Found via a verbose warning.
Most of these are due to: * unused local variables * space before method argument list * space missing between binary operators In a couple cases where there was an unused local variable that looks like the expression itself wasn't needed, this removes the entire line. In one case, there are duplicate when arguments, such as "x" and ?x. These were different in Ruby 1.8, and I'm guessing the desired behavior is either "x" or ?x.ord, since that is the equivalent of the Ruby 1.8 code.
|
I plan to commit this next week unless I hear objections. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of these warnings are harmless, but the first two commits are places where the verbose compile warnings pointed out what appear to be bugs in the library. At least those two commits would benefit from review.