Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix verbose compile warnings #24

Merged
merged 3 commits into from
Mar 23, 2021
Merged

Fix verbose compile warnings #24

merged 3 commits into from
Mar 23, 2021

Commits on Oct 10, 2020

  1. Fix setting of @tpath in Tk::TkTable::CellTag 

    This was found via a verbose warning.  @tpath would always be nil
in the previous code, so attempting to initialize a
Tk::TkTable::CellTag should have always raised a NoMethodError.
    @jeremyevans
    jeremyevans committed Oct 10, 2020
    Configuration menu
    Copy the full SHA
    335390e View commit details
    Browse the repository at this point in the history

  2. Correctly set @id instance variable in TkValidateCommand#_initialize_… 

    …for_cb_class

If cmd was passed a string, this set an unused local variable,
when the apparent intent was to set an instance variable.  Found
via a verbose warning.
    @jeremyevans
    jeremyevans committed Oct 10, 2020
    Configuration menu
    Copy the full SHA
    075896e View commit details
    Browse the repository at this point in the history

  3. Fix remaining verbose compiliation warnings in lib 

    Most of these are due to:

* unused local variables
* space before method argument list
* space missing between binary operators

In a couple cases where there was an unused local variable that
looks like the expression itself wasn't needed, this removes the
entire line.

In one case, there are duplicate when arguments, such as "x" and ?x.
These were different in Ruby 1.8, and I'm guessing the desired
behavior is either "x" or ?x.ord, since that is the equivalent of
the Ruby 1.8 code.
    @jeremyevans
    jeremyevans committed Oct 10, 2020
    Configuration menu
    Copy the full SHA
    d12915f View commit details
    Browse the repository at this point in the history