Initial support lambda node #173
Merged
+16
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this change, typeprof would crash on encountering code like:
```rb
def x = -> { 1 }
```
This was because typeprof did not yet support lambda.
With this update, such lambda definitions are now recognized as `def x: -> Proc`.
While the ideal scenario would be to infer the lambda's type directly (e.g., `^() -> Integer` as in RBS),
this initial step addresses the crash issue and provides basic support.
|
Awesome. I agree that it is reasonable as an initial step, thanks! |
|
I was able to work on this because I had a GOOD FIRST ISSUE GUIDE. Thank you too! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change, typeprof would crash on encountering code like:
This was because typeprof did not yet support lambda.
With this update, such lambda definitions are now recognized as
def x: -> Proc.While the ideal scenario would be to infer the lambda's type directly (e.g.,
^() -> Integeras in RBS), this initial step addresses the crash issue and provides basic support.