-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow shutdown_pipe to be passed in via @config #44
Conversation
I think it's fine to expose this, but we should add a test for it to prevent regressions. |
Test added - thanks for your time Jeremy! |
Thanks for working on this! |
@wishdev Looks like there is a nondeterministic failure in the test: https://github.com/ruby/webrick/runs/894956154 Can you please add a pull request to fix that? Otherwise, I'll probably have to revert. |
on high load-average environments. http://ci.rvm.jp/logfiles/brlog.trunk-no-theap.20200924-222101 |
I'm going to discuss this on #54 because that's where the test code in question lives. |
Because the test for this change was still broken.
I would like to be able to fork a webrick server and then shut it down from the parent process.
The @shutdown_pipe variable within webrick/server is the perfect tool for the job but it is not settable/accessible outside of the class. This patch simply allows for a pipe to be passed in via the server config.