Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invalid use of IP addresses in SNI #83

Merged
merged 1 commit into from
Jan 3, 2022

Conversation

jeremyevans
Copy link
Contributor

Server Name Indication does not allow IP addresses (RFC 6066, section 3:
Literal IPv4 and IPv6 addresses are not permitted in "HostName".).

Recent versions of LibreSSL enforce this requirement, and the tests
currently break when running on such versions. Use localhost
instead of 127.0.0.1 to avoid the issue. This requires adding
HTTPSNITest#connect, because s.hostname= is called before
ssl_socket_connect.

Server Name Indication does not allow IP addresses (RFC 6066, section 3:
`Literal IPv4 and IPv6 addresses are not permitted in "HostName".`).

Recent versions of LibreSSL enforce this requirement, and the tests
currently break when running on such versions.  Use localhost
instead of 127.0.0.1 to avoid the issue.  This requires adding
HTTPSNITest#connect, because s.hostname= is called before
ssl_socket_connect.
@jeremyevans jeremyevans merged commit b5c6876 into ruby:master Jan 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant