CVE-2023-28755: language fix #3006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sorah
commented
Mar 28, 2023
|
|
||
| Please update the uri gem to version 0.12.1 or later. We also release for old uri gem with Ruby releases. Please use them if you need to only security fix. |
There was a problem hiding this comment.
The key part of this patch is to fix the following sentence where hard to understand:
We also release for old uri gem with Ruby releases. Please use them if you need to only security fix.
I need to ask the original author to confirm the intention.
99 tasks
hsbt
approved these changes
Mar 28, 2023
|
Thanks. It's my intentional sentence. I deployed this now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most language have been rewritten for readability.
@hsbt please confirm that the proposed revision reads your intention correctly