Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compatibility note about Regexp::new #3175

Merged
merged 1 commit into from
Apr 24, 2024
Merged

Conversation

MatheusRich
Copy link
Contributor

I couldn't find any mentions of this either in the Ruby 3.3 release note or the 3.2 deprecation that @jeremyevans mentioned.

I'm not sure this should be considered a bugfix, so I added a small mention to this new behavior. LMK if anything else needs to change.

@MatheusRich MatheusRich requested a review from a team as a code owner January 3, 2024 20:20
Copy link
Member

@JuanitoFatas JuanitoFatas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me.

/cc @nurse

@MatheusRich
Copy link
Contributor Author

Anything I can do to get this merged, @JuanitoFatas?

@JuanitoFatas
Copy link
Member

/cc @hsbt what do you think about this PR?

@hsbt
Copy link
Member

hsbt commented Apr 24, 2024

I have no opinion that.

@sorah sorah merged commit f20d96c into ruby:master Apr 24, 2024
@yous yous mentioned this pull request Apr 24, 2024
94 tasks
riseshia added a commit to riseshia/www.ruby-lang.org that referenced this pull request Apr 27, 2024
riseshia added a commit that referenced this pull request Apr 27, 2024
* Import upstream change

Ref: #3175

* Translate imported text

* Update ko/news/_posts/2023-12-25-ruby-3-3-0-released.md

Co-authored-by: Chayoung You <yousbe@gmail.com>

---------

Co-authored-by: Chayoung You <yousbe@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants