Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added gem deep_merge to gemspec #110

Merged
merged 1 commit into from
Jun 27, 2015
Merged

added gem deep_merge to gemspec #110

merged 1 commit into from
Jun 27, 2015

Conversation

firedev
Copy link
Contributor

@firedev firedev commented Jun 27, 2015

When used in Rails together with Deep Merge gem Rails config produces the following error:

/[...]/gems/deep_merge-1.0.1/lib/deep_merge/core.rb:5: warning: already initialized constant DeepMerge::DEFAULT_FIELD_KNOCKOUT_PREFIX
/[...]/gems/rails_config-0.4.2/lib/rails_config/vendor/deep_merge.rb:4: warning: previous definition of DEFAULT_FIELD_KNOCKOUT_PREFIX was here

It is caused by special rails_compat module in deep_merge:

gem 'deep_merge', require: 'deep_merge/rails_compat'

That defines 'deeper_merge' methods on hash: https://github.com/danielsdeleo/deep_merge#using-deep_merge-in-rails

This pull request adds gem deep_merge as dependency to solve this once and for all.

@fredwu
Copy link
Member

fredwu commented Jun 27, 2015

This is great, thank you @firedev! :)

fredwu added a commit that referenced this pull request Jun 27, 2015
added gem deep_merge to gemspec
@fredwu fredwu merged commit 6717826 into rubyconfig:master Jun 27, 2015
@firedev
Copy link
Contributor Author

firedev commented Jun 27, 2015

Thanks, please bump the version up so I can use it in production without referring to GitHub.

@pkuczynski pkuczynski added this to the 0.3.pre milestone Jan 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants