Replace Config::Options#delegate to simple method definitions #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 6, 2017 11:36
delegate method is required ActiveSupport. So it would raise NoMethodError with running in not rails environment.
|
Thanks for the fix. Could you please add a test for it? |
|
Well, we need to add not-rails environment to test it. I would try it by Sinatra. |
|
Cool, thanks! That should be easily possible with Appraisals |
added 5 commits
November 7, 2017 09:24
yhatt
commented
Nov 7, 2017
spec/spec_helper.rb
Outdated
|
|
||
| def fixture_path |
There was a problem hiding this comment.
For preventing to fail current specs, I defined fixture_path manually in sinatra test. fixture_path is provided by rspec-rails.
|
Yay, checks passed! Adding sinatra test was a bit harder than I thought 😅 |
|
You did a great job! :) I am waiting for Travis to report the build status and we can merge it in :) |
|
All good! Merging in and releasing... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #184.
Config::Options#delegateis using ActiveSupport's#delegateimplicitly. So it would raiseNoMethodErrorwith running in not rails environment. e.g. Padrino, Sinatra and pure Ruby.It could fix it by replacing to simple method definitions.