Add Rails 6.0 to the test matrix #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also fixed CI, so it's green. |
|
I can break it into separate commits/PRs (CI fix, rails-6 support, fixing deprecation) if you prefer. |
pyromaniac
reviewed
Dec 11, 2019
pyromaniac
previously approved these changes
Dec 11, 2019
prevents deprecation warning with rails-6 Also while we're here add rails-6 to the travis matrix
pyromaniac
previously approved these changes
Dec 16, 2019
pkuczynski
reviewed
Jan 3, 2020
pkuczynski
reviewed
Jan 4, 2020
pkuczynski
changed the title
pkuczynski
changed the title
pkuczynski
reviewed
Jan 4, 2020
This was referenced Jan 6, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
prevents deprecation warning with rails-6:
DEPRECATION WARNING: Initialization autoloaded the constants ActionText::ContentHelper and ActionText::TagHelper.Also while we're here add rails-6 to the travis matrix