Separates Admin and Volunteer Dashboards #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Explanation: The volunteer and admin stories for the dashboard were starting to diverge so to limit conditionals throughout the view, this commit separates the volunteer and admin dashboards into two separate partials. Because there are only two views, This PR: - Removes CaseContacts table from Admin Dashboard - Adds 'Last Case Contact' field to volunteers table on Admin Dashboard - Adds 'Contacts Made in Last 60 days' to volunteers table on Admin Dashboard - Simplifies User Dashboard by removing jquery from cases table
compwron
approved these changes
Apr 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #158
Resolves #96
Resolves #94
Description
Explanation:
The volunteer and admin stories for the dashboard were starting to diverge
so to limit conditionals throughout the view, this commit separates the
volunteer and admin dashboards into two separate partials. It might be cleaner
to separate the views at the routes level with constraints down the road, but
for now since we only have the two paths, I think the partials are fine.
This PR:
Type of change
How will this affect user permissions?
Removes a large number of pundit policy checks in favor of one master check.
How Has This Been Tested?
Local testing and existing Rspecs pass
Screenshots