Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Volunteer invite and login info expansion #1904

Merged
merged 1 commit into from
Apr 5, 2021

Conversation

compwron
Copy link
Collaborator

@compwron compwron commented Apr 3, 2021

What github issue is this PR for, if any?

none

What changed, and why?

add move info for supervisors and admins to see about a volunteer invite and login
Also split out some partials not for current reuse but just to make erb files smaller

How will this affect user permissions?

  • Volunteer permissions: volunteer can see more info about their invites and logins
  • Supervisor permissions: can see more info about volunteer invites and logins
  • Admin permissions: can see more info about volunteer invites and logins

How is this tested? (please write tests!) 💖💪

rspec

Screenshots please :)

Screen Shot 2021-04-04 at 7 54 54 PM
Screen Shot 2021-04-04 at 7 54 40 PM
Screen Shot 2021-04-04 at 7 49 52 PM
Screen Shot 2021-04-04 at 7 49 30 PM
Screen Shot 2021-04-04 at 7 49 10 PM

@compwron compwron force-pushed the volunteer-login-info-tuning branch from 5f4cf7a to 1afe84f Compare April 5, 2021 02:51
@github-actions github-actions bot added ruby Pull requests that update Ruby code Tests! 🎉💖👏 labels Apr 5, 2021
@compwron compwron changed the title WIP user login info tuning Volunteer invite and login info expansion Apr 5, 2021
@compwron compwron merged commit be1bdaf into main Apr 5, 2021
@compwron compwron deleted the volunteer-login-info-tuning branch April 5, 2021 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ruby Pull requests that update Ruby code Tests! 🎉💖👏
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant