Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFG 2023] Move Distributions card to Distributions | Summary #3723

Closed
2 tasks done
cielf opened this issue Jul 9, 2023 · 3 comments
Closed
2 tasks done

[RFG 2023] Move Distributions card to Distributions | Summary #3723

cielf opened this issue Jul 9, 2023 · 3 comments
Assignees
@carlost
Labels
Ruby for Good 2023 DC Created for Ruby for Good 2023 DC
Milestone
Dashboard Reorgan...

Comments

@cielf
Copy link
Collaborator

cielf commented Jul 9, 2023 •
edited by carlost
Loading

Summary

Move the Distributions functionality from the dashboard to the left hand menu

Why

Part of Dashboard rework

Details

We are talking about the card accessed from the dashboard as "Distributions"
This will require a new controller and view
A view containing this info will be be accessed via the left hand menu by clicking "Reporting & Auditing" then "Distribution Summary"
The card will be removed from the dashboard
Note that we'll need the filtering functionality in the new view

Other things you should know

We are grouping a number of dashboard-related changes together and will merge these individual changes into a long lived dashboard-related branch. We will merge this long lived branch into main when we are ready to release the whole suite.

We may want to make the filtering functionality a common element between all of these separate reports (if it isn't already)

Criteria for completion

  • Dashboard Distributions functionality moved - now accessed via left hand menu
  • Tests modified accordingly
@cielf cielf added the Ruby for Good 2023 DC Created for Ruby for Good 2023 DC label Jul 9, 2023
@carlost carlost self-assigned this Jul 28, 2023
@carlost
Copy link
Collaborator

carlost commented Jul 28, 2023

after talking to @scooter-dangle @awwaiid we have decided to:

  • we will not be using flipper feature flags. instead of hiding these changes behind feature flags, we will merge all of the various dashboard change issues into a long lived dashboard branch (which does not exist as of now). We will merge the dashboard branch into main once we have completed the various dashboard issues.
  • we will add the menu item for the new views under "Reporting & Auditing". This will avoid the need for significant changes to several of the existing menu items (e.g. turning the current "Distributions" menu item into a submenu etc) and aggregate all of the new menu items in one location.

@dorner
Copy link
Collaborator

dorner commented Jul 28, 2023

Not sure I understand this. @scooter-dangle @awwaiid . Long lived feature branches are a nightmare to deal with. Is there a reason we can't have a separate route + view for the new dashboard and simply not link it anywhere until it's ready to replace the existing one?

rae-stanton added a commit that referenced this issue Jul 30, 2023
@rae-stanton
Distributions summary
040996b 
Fixes issue #3723

Changes made:
This creates a new area for distributions summary to live under audits, adds system/page spec for testing.
rae-stanton added a commit that referenced this issue Jul 30, 2023
@rae-stanton
Distributions summary
a2ee019 
Fixes issue #3723

Changes made:
This creates a new area for distributions summary to live under audits, adds system/page spec for testing.
rae-stanton added a commit that referenced this issue Jul 30, 2023
@rae-stanton
Distributions summary
a3a8dc7 
Fixes issue #3723

Changes made:
This creates a new area for distributions summary to live under audits, adds system, page, and request spec for testing.
rae-stanton added a commit that referenced this issue Jul 30, 2023
@rae-stanton
Distributions summary
135bd45 
Fixes issue #3723

Changes made:
This creates a new area for distributions summary to live under audits, adds system, page, and request spec for testing.

sidebar - we also fixed the weird issue with the sidebar for the annual reports, distributions by county, and itemized donations that were not staying selected.
rae-stanton added a commit that referenced this issue Jul 30, 2023
@rae-stanton
Distributions summary
71c87fc 
Fixes issue #3723

Changes made:
This creates a new area for distributions summary to live under audits, adds system, page, and request spec for testing.

sidebar - we also fixed the weird issue with the sidebar for the annual reports, distributions by county, and itemized donations that were not staying selected.
rae-stanton added a commit that referenced this issue Jul 30, 2023
@rae-stanton
Distributions summary
5ed4e7e 
Fixes issue #3723

Changes made:
This creates a new area for distributions summary to live under audits, adds system, page, and request spec for testing.

sidebar - we also fixed the weird issue with the sidebar for the annual reports, distributions by county, and itemized donations & distributions that were not staying selected.
@rae-stanton rae-stanton mentioned this issue Jul 30, 2023
Merged
awwaiid added a commit that referenced this issue Jul 30, 2023
@awwaiid
Clean out some lint! [#3723]
c6b0625
awwaiid added a commit that referenced this issue Jul 30, 2023
@awwaiid
Merge pull request #3802 from rubyforgood/3723-distributions-summary
ab21419 
Distributions summary #3723
@awwaiid
Copy link
Collaborator

awwaiid commented Jul 30, 2023

PR merged! Follow up improvements will be done in separate issue/PRs as directed by a whole-epic QA

@awwaiid awwaiid closed this as completed Jul 30, 2023
@awwaiid awwaiid added this to the Dashboard Update milestone Nov 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@carlost carlost

Labels
Ruby for Good 2023 DC Created for Ruby for Good 2023 DC
Projects
None yet
Milestone
Dashboard Reorganization
Development

No branches or pull requests
4 participants
@awwaiid @carlost @dorner @cielf