Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distributions summary #3723 #3802

Merged
merged 2 commits into from
Jul 30, 2023
Merged

Distributions summary #3723 #3802

merged 2 commits into from
Jul 30, 2023

Conversation

rae-stanton
Copy link
Collaborator

Fixes issue #3723

Changes made:
This creates a new area for distributions summary to live under audits, adds system, page, and request spec for testing.

sidebar - we also fixed the weird issue with the sidebar for the annual reports, distributions by county, and itemized donations & distributions that were not staying selected.

Resolves #3723

Type of change

  • New(ish) feature (non-breaking change which adds functionality)
  • This just moved the dashboard card for the distributions summary to the audits area

How Has This Been Tested?

The following tests are being used here:
System tests

  • testing everything that was previously in the dashboard area and moving it to its new home (also simulating data)
  • simulating date selection & populated data as a result
    Requests spec
  • for logged in or not logged in individuals with a redirect

Fixes issue #3723

Changes made:
This creates a new area for distributions summary to live under audits, adds system, page, and request spec for testing.

sidebar - we also fixed the weird issue with the sidebar for the annual reports, distributions by county, and itemized donations & distributions that were not staying selected.
@awwaiid
Copy link
Collaborator

awwaiid commented Jul 30, 2023

litttttllleee lint

@awwaiid awwaiid merged commit ab21419 into dashboard Jul 30, 2023
12 checks passed
@awwaiid awwaiid deleted the 3723-distributions-summary branch July 30, 2023 16:48
@awwaiid awwaiid added the Ruby for Good 2023 DC Created for Ruby for Good 2023 DC label Jul 30, 2023
@awwaiid awwaiid added this to the Dashboard Update milestone Nov 12, 2023
Copy link
Contributor

@rae-stanton: Your PR Distributions summary #3723 is part of today's Human Essentials production release: 2024.05.26.
Thank you very much for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ruby for Good 2023 DC Created for Ruby for Good 2023 DC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants