[UPDATE] added contributing guidelines #3167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikhilbhatt
force-pushed
the
change_readme
branch
4 times, most recently
from
85d546a
to
e584594
Compare
nikhilbhatt
force-pushed
the
change_readme
branch
from
e584594
to
e26f5cf
Compare
seanmarcia
reviewed
Oct 3, 2022
|
|
||
| 1. Add a test for your change. If you are adding functionality or fixing a bug, you should add a test! | ||
|
|
||
| 1. Run linters and fix any linting errors they brings up. |
There was a problem hiding this comment.
I don't think this repo uses these git hooks.
There was a problem hiding this comment.
I think I'd recommend changing this to having the user run 'rubocop -a' like is recommended in the readme file :)
|
Thanks for this! Looks great now :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3158
Description
Type of change
How Has This Been Tested?
Screenshots