3742 low inventory report #3857
Conversation
|
To-Do:
|
If there is a minimum of 0 and amount of 0, the equality check used to return that inventory item, which we don't want. The cleanest way to handle this is to only return if the inventory levels are lower.
| let(:recommended_quantity) { 200 } | ||
|
|
||
| it { is_expected.to include inventory_item } | ||
| end |
There was a problem hiding this comment.
I actually prefer having one big test that has all your data set up and returns a list where we check to see that all the expected data is in it and none of the unexpected data is. The only other case you need is a zero case where it returns nothing. It's much faster than creating all the data multiple times.
spec/system/dashboard_system_spec.rb
Outdated
| end | ||
| end | ||
| end | ||
| end |
There was a problem hiding this comment.
This donation section doesn't currently exist in the dashboard page. This PR is pointed into the dashboard branch which currently has failing specs. There's a note in the commit message. This commit is available in a separate PR, but that one hasn't been merged yet.
|
@ChaelCodes: Your PR |
Resolves #3742
Description
This PR adds a low inventory report to the dashboard.
Type of change
How Has This Been Tested?
Screenshots
New low inventory report:
