Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added title tags to all top level pages #81

Merged
merged 1 commit into from
May 21, 2017

Conversation

sunsheeppoplar
Copy link
Contributor

closes #54

I didn't see any tests for views, so I assumed this would be fine?

@cattywampus
Copy link
Collaborator

Yeah, don't worry about the view tests. This is great. Thanks a lot!

👍

@sunsheeppoplar
Copy link
Contributor Author

Sure, no problem! Do y'all think this will be an ongoing thing beyond this weekend? Love the idea. Would love to contribute to more of functionality of it - just figured I'd take an easy one to start with!

@cattywampus
Copy link
Collaborator

Absolutely. This is something we are going to continue to support throughout the year. We still have lots of issues left open and more issues to create as we gather more input from our stakeholder.

@cattywampus
Copy link
Collaborator

Are you at #rubyforgood? If not, how did you find the project?

@armahillo
Copy link
Collaborator

Thanks, Abner!!

@sunsheeppoplar
Copy link
Contributor Author

I'm not. I was just looking to work on some of my own projects earlier when I saw that one of my classmates had forked the Ruby For Good general repo. Y'all's project jumped out at me and I was excited to see that your issues and project as a whole seemed really well organized, so I decided to grab an easy to ticket (had a long day fixing some work bugs, so I was a bit brain-dead anyhow lol)

@cattywampus
Copy link
Collaborator

Wow. So cool that you found us and we really appreciate the contrib.

@cattywampus cattywampus merged commit 60200e9 into rubyforgood:master May 21, 2017
@abachman
Copy link
Member

@sunsheeppoplar That's awesome! You rock.

@armahillo armahillo added this to the RFG 2017 milestone May 21, 2017
@armahillo armahillo added Repo First-timer This Pull Request is a user's first contribution to Diaperbase and removed enhancement labels May 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Repo First-timer This Pull Request is a user's first contribution to Diaperbase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add title to pages
4 participants