This repository has been archived by the owner on Nov 6, 2021. It is now read-only.
Prevent hiding children, family, and family request list results due to pagination #398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edwinthinks
changed the title
scooter-dangle
deleted the
395/show-all-children-and-family-results-instead-of-pagination
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #395
Description
Our partner users are getting confused because they are unable to scroll through all their children, family, or family request records. This was due to the addition of
.paginationwhich forced the results to be limited to 25 records. Normally pagination would be great, but we are missing buttons to navigate between pagination pages and it seems to be a larger lift to change that behavior.I think we should introduce pagination again when performance becomes an issue. However, for now I suggest we just remove it until we get to that point.
Type of change
How Has This Been Tested?