Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the responsiveness of the team member photo and social media #39

Closed
wants to merge 3 commits into from

Conversation

FionaDL
Copy link
Contributor

@FionaDL FionaDL commented Nov 17, 2021

This PR fixes issue: #20

I consulted with @meg-gutshall, and made the photo full width in smaller devices. I also moved the title to be above the photo and centered under the red line. Also, we are hiding the slash between the social media links on small devices and moving them to separate lines.

127 0 0 1_4000_our-team_sean-marcia(iPhone X) (3)
Screen Shot 2021-11-16 at 10 41 11 PM
Screen Shot 2021-11-16 at 10 41 18 PM

@meg-gutshall
Copy link
Member

Hi Fiona! The screenshots look perfect! Thank you so much for your hard work!

I tried to merge it in just now and it's not appearing as it does in your screenshots. I was informed that the navigation is missing on the mobile view so I have a feeling it has something to do with that and not your code. I'm going to look into it and try to sort out this mess of a stylesheet. I will let you know when that's done and then we'll get your changes merged in.

Thanks again!

@meg-gutshall meg-gutshall deleted the branch rubyforgood:dev April 22, 2022 17:16
@meg-gutshall meg-gutshall self-requested a review July 20, 2022 15:52
@meg-gutshall meg-gutshall added the TODO Don't forget this! label Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TODO Don't forget this!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants