-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace node-sass with sass (Dart Sass) #692
Replace node-sass with sass (Dart Sass) #692
Conversation
Signed-off-by: Takuya Noguchi <takninnovationresearch@gmail.com>
@tnir Any reason for not creating PRs from the main repository? It's helpful to have review apps by default. |
@deivid-rodriguez While I want to do so, in my Gitpod environment I cannot still have the (Write) permission to rubygems/bundler-site repo. After you invited me to this repo, I already requested it on the following page from https://gitpod.io/new: I thinks this is a kind of limitation from Gitpod when the Gitpod/GitHub integration per GitHub Org is not allowed:
A workaround for it would be to use SSH key instead of HTTPS. But due to another limitation of Gitpod, I think I add the SSH key to Sorry for your inconvenience to increase your work. |
Don't worry. Is there anything I can do so that you can get this fixed? Should I install gitpod on this repo? |
@tnir I approved to request for gitpod now. |
I think permission is granted per user. Ask any of rubygems Org owners (I cannot see each member is Org Owner or Org Member) to allow me to use after they confirm how Gitpod integration affects the Org. The following resources might be helpful: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
What was the end-user problem that led to this PR?
node-sass (LibSass) has been deprecated.
What was your diagnosis of the problem?
sass (Dart Sass) is the active package.
What is your fix for the problem, implemented in this PR?
Replace node-sass with sass.
Why did you choose this fix out of the possible options?
webpack build (
npx webpack -d source-map --progress --color
) gets slow 2x times (from 1700-2000ms to 3900-4400ms on my local).fibers
package is not recommended for Node.js 16+, so I guess we cannot use it any more.webpack build performance on Actions
before: https://github.com/rubygems/bundler-site/runs/7360832092?check_suite_focus=true
after: https://github.com/rubygems/bundler-site/runs/7361858411?check_suite_focus=true
Signed-off-by: Takuya Noguchi takninnovationresearch@gmail.com