Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify legacy install sub-command page to man page #695

Merged
merged 1 commit into from
Jul 23, 2022

Conversation

tnir
Copy link
Collaborator

@tnir tnir commented Jul 16, 2022

What was the end-user problem that led to this PR?

The problem is shown in #694.

Closes #694

What was your diagnosis of the problem?

All /bundle_install.htmls should be migrated to /man/bundle-install.1.html generated from rubygems/rubygems/bundler while they are diverged and bundler_install in this repo has been less updated.

What is your fix for the problem, implemented in this PR?

  • git rm source/**/bundle_install.html.haml
  • Add redirection from /bundle_install.html to /man/bundle-install.1.html
  • Add redirections from /v:version/bundle_install.html to /v:version/man/bundle-install.1.html

Why did you choose this fix out of the possible options?

Each sub-command should be migrated than all sub-commands are migrated once in oder to confirm the differences between ones in this repo and ones in the upstream.

Signed-off-by: Takuya Noguchi takninnovationresearch@gmail.com

@deivid-rodriguez deivid-rodriguez temporarily deployed to bundler-site-tnir-unify-rpcmuf July 16, 2022 11:55 Inactive
@tnir tnir self-assigned this Jul 23, 2022
@tnir
Copy link
Collaborator Author

tnir commented Jul 23, 2022

This PR will follow #695

Signed-off-by: Takuya Noguchi <takninnovationresearch@gmail.com>
@tnir tnir force-pushed the tnir-unify-bundle-install branch from 7bf56e5 to 76d6972 Compare July 23, 2022 12:55
@tnir tnir marked this pull request as ready for review July 23, 2022 12:56
@tnir tnir assigned deivid-rodriguez and unassigned tnir Jul 23, 2022
@tnir
Copy link
Collaborator Author

tnir commented Jul 23, 2022

@deivid-rodriguez What do you think?

Copy link
Member

@deivid-rodriguez deivid-rodriguez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like with others, if these are equivalent, just the manual page is more up to date, this seems fine!

@tnir
Copy link
Collaborator Author

tnir commented Jul 23, 2022

if these are equivalent [...]

No. Resources in this repo are obsolete compared ones with the upstream rather than equivalent.

@tnir tnir assigned tnir and unassigned deivid-rodriguez Jul 23, 2022
@tnir tnir merged commit 7070b65 into master Jul 23, 2022
@tnir tnir deleted the tnir-unify-bundle-install branch July 23, 2022 13:46
@tnir
Copy link
Collaborator Author

tnir commented Jul 23, 2022

Merging.

@deivid-rodriguez
Copy link
Member

Yes, that's what I meant, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integrate bundle_install with man from rubygems/rubygems/bundler
2 participants