Skip to content
This repository has been archived by the owner on Apr 14, 2021. It is now read-only.

Pulling in Thor changes to print friendly error on ambiguous command #2574

Closed
wants to merge 1 commit into from

Conversation

ssrihari
Copy link

Fixes #2550

@gnufied
Copy link
Contributor

gnufied commented Jul 31, 2013

Thank you for opening this PR. It needs wee bit more work though:

nomads/bundler git:(master)* ruby -S ./bin/bundle i
nomads/bundler git:(master)* 

Which means it silently returns the prompt rather than printing the actual error. The reason it prints nothing is because - Bundler.ui does not really point to a printable logger yet. Only when Bundler::CLI is initialized it points to something that can actually print.

@indirect
Copy link
Member

@gnufied the RailsGirls team has a patch (with tests) that fixes those things, so I'll update Thor on master and let them know they can catch the new exception.

@ssrihari thanks for getting this fixed in Thor!

@indirect
Copy link
Member

Changes merged as part of 04f8e4b.

@indirect indirect closed this Jul 31, 2013
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Print friendly error on ambiguous command
3 participants