This repository has been archived by the owner on Apr 14, 2021. It is now read-only.
deprecate the bundle viz command #5964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We also need a feature flag around the definition of the command in CLI so that a plugin can pick it up (or just call This also requires a |
colby-swandale
force-pushed
the
colby/deprecate-viz-command
branch
from
5314137
to
e825843
Compare
|
|
colby-swandale
force-pushed
the
colby/deprecate-viz-command
branch
from
e825843
to
60423a5
Compare
|
☔ The latest upstream changes (presumably #5995) made this pull request unmergeable. Please resolve the merge conflicts. |
|
@indirect thoughts? |
|
@segiddins This works for me. If @colby-swandale is too busy to finish it, can you rebase it and fix the bool key thing? |
colby-swandale
force-pushed
the
colby/deprecate-viz-command
branch
from
60423a5
to
0b04562
Compare
|
Bye-bye @bundlerbot r+ |
|
📌 Commit 0b04562 has been approved by |
bundlerbot
added a commit
that referenced
this pull request
Sep 6, 2017
deprecate the bundle viz command ### What was the end-user problem that led to this PR? The `bundle viz` command is to been removed from bundler 2 and extracted into a plugin Closes #5180 ### What is your fix for the problem, implemented in this PR? Deprecate the `bundle viz` command with an error explaining that a new gem will replace it's functionality.
|
☀️ Test successful - status-travis |
colby-swandale
pushed a commit
that referenced
this pull request
Sep 22, 2018
deprecate the bundle viz command ### What was the end-user problem that led to this PR? The `bundle viz` command is to been removed from bundler 2 and extracted into a plugin Closes #5180 ### What is your fix for the problem, implemented in this PR? Deprecate the `bundle viz` command with an error explaining that a new gem will replace it's functionality. (cherry picked from commit dbb0aed)
colby-swandale
pushed a commit
that referenced
this pull request
Sep 22, 2018
deprecate the bundle viz command ### What was the end-user problem that led to this PR? The `bundle viz` command is to been removed from bundler 2 and extracted into a plugin Closes #5180 ### What is your fix for the problem, implemented in this PR? Deprecate the `bundle viz` command with an error explaining that a new gem will replace it's functionality. (cherry picked from commit dbb0aed)
colby-swandale
added a commit
that referenced
this pull request
Oct 25, 2018
* 1-17-stable: (38 commits) Version 1.17.0 with changelog Merge #6754 Version 1.17.0.pre.2 with changelog fix failing bundle remove specs Still document the `--force` option scope specs testing bundler 2 deprecations to bundler 1 only Merge #6718 Merge #6707 Merge #6702 Merge #6316 Auto merge of #6447 - agrim123:agr-update-error-message, r=segiddins Auto merge of #6513 - agrim123:agr-bundler-remove, r=indirect Auto merge of #6318 - jhawthorn:fix_incorrect_test_in_requires_sudo, r=segiddins Auto merge of #6450 - bundler:segiddins/bundle-binstubs-all, r=colby-swandale Auto merge of #6024 - gwerbin:custom-user-bundle-dir, r=colby-swandale Version 1.17.0.pre.1 with changelog Auto merge of #5964 - bundler:colby/deprecate-viz-command, r=segiddins Auto merge of #5986 - bundler:seg-jobs-count, r=indirect Auto merge of #5995 - bundler:seg-gvp-major, r=indirect Auto merge of #5803 - igorbozato:path_relative_to_pwd, r=indirect ...
This was referenced Jul 21, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user problem that led to this PR?
The
bundle vizcommand is to been removed from bundler 2 and extracted into a pluginCloses #5180
What is your fix for the problem, implemented in this PR?
Deprecate the
bundle vizcommand with an error explaining that a new gem will replace it's functionality.