This repository has been archived by the owner on Apr 14, 2021. It is now read-only.
[Binstubs] Add --all options #6450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
segiddins
commented
Mar 22, 2018
spec/commands/binstubs_spec.rb
Outdated
|
|
||
| bundle "binstubs rack", :all => true | ||
| expect(last_command).to be_failure | ||
| expect(last_command.stderr).to include("Cannot specify --all with specific gems") |
segiddins
force-pushed
the
segiddins/bundle-binstubs-all
branch
from
57293ab
to
0fc018f
Compare
colby-swandale
approved these changes
Apr 15, 2018
|
Just needs to adjust the failing spec to use |
segiddins
force-pushed
the
segiddins/bundle-binstubs-all
branch
from
0fc018f
to
97876bd
Compare
|
Should be fixed now, sorry |
segiddins
force-pushed
the
segiddins/bundle-binstubs-all
branch
from
97876bd
to
ecda83c
Compare
|
Thanks! @bundlerbot r+ |
|
📌 Commit ecda83c has been approved by |
bundlerbot
added a commit
that referenced
this pull request
Apr 19, 2018
…swandale [Binstubs] Add --all options ### What was the end-user problem that led to this PR? The problem was we have removed the `--binstubs` argument to `bundle install`, so saying "oh well, lets install all the bin stubs" became more tedious, requiring multiple calls to `bundle binstubs` and probably some swearing since you forgot what gem contains what binstub. ### What was your diagnosis of the problem? My diagnosis was we need a one-liner to generate bin stubs for all gems. ### What is your fix for the problem, implemented in this PR? My fix adds such an option to `bundle binstubs`! ### Why did you choose this fix out of the possible options? I chose this fix because it keeps binstub generation in its own command, rather than continuing to piggy-back off of `install`
|
☀️ Test successful - status-travis |
colby-swandale
pushed a commit
that referenced
this pull request
Oct 9, 2018
…swandale [Binstubs] Add --all options ### What was the end-user problem that led to this PR? The problem was we have removed the `--binstubs` argument to `bundle install`, so saying "oh well, lets install all the bin stubs" became more tedious, requiring multiple calls to `bundle binstubs` and probably some swearing since you forgot what gem contains what binstub. ### What was your diagnosis of the problem? My diagnosis was we need a one-liner to generate bin stubs for all gems. ### What is your fix for the problem, implemented in this PR? My fix adds such an option to `bundle binstubs`! ### Why did you choose this fix out of the possible options? I chose this fix because it keeps binstub generation in its own command, rather than continuing to piggy-back off of `install` (cherry picked from commit e5c0686)
colby-swandale
added a commit
that referenced
this pull request
Oct 25, 2018
* 1-17-stable: (38 commits) Version 1.17.0 with changelog Merge #6754 Version 1.17.0.pre.2 with changelog fix failing bundle remove specs Still document the `--force` option scope specs testing bundler 2 deprecations to bundler 1 only Merge #6718 Merge #6707 Merge #6702 Merge #6316 Auto merge of #6447 - agrim123:agr-update-error-message, r=segiddins Auto merge of #6513 - agrim123:agr-bundler-remove, r=indirect Auto merge of #6318 - jhawthorn:fix_incorrect_test_in_requires_sudo, r=segiddins Auto merge of #6450 - bundler:segiddins/bundle-binstubs-all, r=colby-swandale Auto merge of #6024 - gwerbin:custom-user-bundle-dir, r=colby-swandale Version 1.17.0.pre.1 with changelog Auto merge of #5964 - bundler:colby/deprecate-viz-command, r=segiddins Auto merge of #5986 - bundler:seg-jobs-count, r=indirect Auto merge of #5995 - bundler:seg-gvp-major, r=indirect Auto merge of #5803 - igorbozato:path_relative_to_pwd, r=indirect ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user problem that led to this PR?
The problem was we have removed the
--binstubsargument tobundle install, so saying "oh well, lets install all the bin stubs" became more tedious, requiring multiple calls tobundle binstubsand probably some swearing since you forgot what gem contains what binstub.What was your diagnosis of the problem?
My diagnosis was we need a one-liner to generate bin stubs for all gems.
What is your fix for the problem, implemented in this PR?
My fix adds such an option to
bundle binstubs!Why did you choose this fix out of the possible options?
I chose this fix because it keeps binstub generation in its own command, rather than continuing to piggy-back off of
install