This repository has been archived by the owner on Apr 14, 2021. It is now read-only.
Following up ruby core changes. #6818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* To use libexec instead of bin directory. * Restore exe direcotry for bundler.gemspec while running test suite.
colby-swandale
approved these changes
Nov 28, 2018
|
@bundlerbot r+ |
ghost
pushed a commit
that referenced
this pull request
Dec 1, 2018
6818: Following up ruby core changes. r=hsbt a=hsbt ### What is your fix for the problem, implemented in this PR? These changes enabled to use the same configuration of executables in ruby core repository. * To use libexec instead of bin directory. * Restore exe direcotry for bundler.gemspec while running test suite. ### Why did you choose this fix out of the possible options? The ruby core repository uses `exe` directory for other usage. I chose `libexec` instead of `exe` in ruby core. And, The location of `bundler.gemspec` is not the root of the repository on ruby core. We should restore `libexec` to `exe` under the `lib` dir. see. https://github.com/ruby/ruby/blob/trunk/lib/bundler.gemspec Co-authored-by: SHIBATA Hiroshi <hsbt@ruby-lang.org>
Build succeeded |
ghost
merged commit
colby-swandale
pushed a commit
that referenced
this pull request
Dec 4, 2018
6818: Following up ruby core changes. r=hsbt a=hsbt ### What is your fix for the problem, implemented in this PR? These changes enabled to use the same configuration of executables in ruby core repository. * To use libexec instead of bin directory. * Restore exe direcotry for bundler.gemspec while running test suite. ### Why did you choose this fix out of the possible options? The ruby core repository uses `exe` directory for other usage. I chose `libexec` instead of `exe` in ruby core. And, The location of `bundler.gemspec` is not the root of the repository on ruby core. We should restore `libexec` to `exe` under the `lib` dir. see. https://github.com/ruby/ruby/blob/trunk/lib/bundler.gemspec Co-authored-by: SHIBATA Hiroshi <hsbt@ruby-lang.org> (cherry picked from commit a578c4e)
hsbt
pushed a commit
that referenced
this pull request
Dec 11, 2018
6818: Following up ruby core changes. r=hsbt a=hsbt ### What is your fix for the problem, implemented in this PR? These changes enabled to use the same configuration of executables in ruby core repository. * To use libexec instead of bin directory. * Restore exe direcotry for bundler.gemspec while running test suite. ### Why did you choose this fix out of the possible options? The ruby core repository uses `exe` directory for other usage. I chose `libexec` instead of `exe` in ruby core. And, The location of `bundler.gemspec` is not the root of the repository on ruby core. We should restore `libexec` to `exe` under the `lib` dir. see. https://github.com/ruby/ruby/blob/trunk/lib/bundler.gemspec Co-authored-by: SHIBATA Hiroshi <hsbt@ruby-lang.org> (cherry picked from commit a578c4e) (cherry picked from commit 1871506)
colby-swandale
added a commit
that referenced
this pull request
Dec 11, 2018
colby-swandale
added a commit
that referenced
this pull request
Jan 4, 2019
* 2-0-stable: (39 commits) Version 2.0.1 with changelog update tested rubygems in travis Lower required RubyGems to 2.5 or greater Bundler 2.0 with changelog update CHANGELOG with new changes and release Merge #6856 add RubyGems v3.0.1 to rg clone task Version 2.0.0.pre.3 wih changelog update tested versions of RubyGems in travis update gemspec to require RubyGems 3.0.0 Merge #6849 Merge #6853 Revert "Version 2.0.0 with changelog" Version 2.0.0 with changelog fix breaking edge case spec Merge #6818 bump bundler_2_mode in inject spec Version 2.0.0.pre.2 with Changelog fix failing major deprecation error spec remove :github source declaration from new gem template ...
colby-swandale
added a commit
that referenced
this pull request
Feb 10, 2019
* 2-0-stable: (43 commits) remove path that i copied from my personal computer Auto merge of #6586 - bundler:segiddins/softer-major-deprecations, r=indirect Merge #6941 Merge #6834 Version 2.0.1 with changelog update tested rubygems in travis Lower required RubyGems to 2.5 or greater Bundler 2.0 with changelog update CHANGELOG with new changes and release Merge #6856 add RubyGems v3.0.1 to rg clone task Version 2.0.0.pre.3 wih changelog update tested versions of RubyGems in travis update gemspec to require RubyGems 3.0.0 Merge #6849 Merge #6853 Revert "Version 2.0.0 with changelog" Version 2.0.0 with changelog fix breaking edge case spec Merge #6818 ...
colby-swandale
added a commit
that referenced
this pull request
Feb 12, 2019
* 2-0-stable: (43 commits) remove path that i copied from my personal computer Auto merge of #6586 - bundler:segiddins/softer-major-deprecations, r=indirect Merge #6941 Merge #6834 Version 2.0.1 with changelog update tested rubygems in travis Lower required RubyGems to 2.5 or greater Bundler 2.0 with changelog update CHANGELOG with new changes and release Merge #6856 add RubyGems v3.0.1 to rg clone task Version 2.0.0.pre.3 wih changelog update tested versions of RubyGems in travis update gemspec to require RubyGems 3.0.0 Merge #6849 Merge #6853 Revert "Version 2.0.0 with changelog" Version 2.0.0 with changelog fix breaking edge case spec Merge #6818 ...
colby-swandale
added a commit
that referenced
this pull request
Feb 18, 2019
* commit '77f4c15451aaac135d19ac5d1637981d7b05d799': (43 commits) remove path that i copied from my personal computer Auto merge of #6586 - bundler:segiddins/softer-major-deprecations, r=indirect Merge #6941 Merge #6834 Version 2.0.1 with changelog update tested rubygems in travis Lower required RubyGems to 2.5 or greater Bundler 2.0 with changelog update CHANGELOG with new changes and release Merge #6856 add RubyGems v3.0.1 to rg clone task Version 2.0.0.pre.3 wih changelog update tested versions of RubyGems in travis update gemspec to require RubyGems 3.0.0 Merge #6849 Merge #6853 Revert "Version 2.0.0 with changelog" Version 2.0.0 with changelog fix breaking edge case spec Merge #6818 ...
colby-swandale
added a commit
that referenced
this pull request
Feb 20, 2019
* 2-0-stable: (43 commits) remove path that i copied from my personal computer Auto merge of #6586 - bundler:segiddins/softer-major-deprecations, r=indirect Merge #6941 Merge #6834 Version 2.0.1 with changelog update tested rubygems in travis Lower required RubyGems to 2.5 or greater Bundler 2.0 with changelog update CHANGELOG with new changes and release Merge #6856 add RubyGems v3.0.1 to rg clone task Version 2.0.0.pre.3 wih changelog update tested versions of RubyGems in travis update gemspec to require RubyGems 3.0.0 Merge #6849 Merge #6853 Revert "Version 2.0.0 with changelog" Version 2.0.0 with changelog fix breaking edge case spec Merge #6818 ... (cherry picked from commit 77f4c15)
deivid-rodriguez
pushed a commit
that referenced
this pull request
Feb 28, 2019
* 2-0-stable: (43 commits) remove path that i copied from my personal computer Auto merge of #6586 - bundler:segiddins/softer-major-deprecations, r=indirect Merge #6941 Merge #6834 Version 2.0.1 with changelog update tested rubygems in travis Lower required RubyGems to 2.5 or greater Bundler 2.0 with changelog update CHANGELOG with new changes and release Merge #6856 add RubyGems v3.0.1 to rg clone task Version 2.0.0.pre.3 wih changelog update tested versions of RubyGems in travis update gemspec to require RubyGems 3.0.0 Merge #6849 Merge #6853 Revert "Version 2.0.0 with changelog" Version 2.0.0 with changelog fix breaking edge case spec Merge #6818 ... (cherry picked from commit 77f4c15)
deivid-rodriguez
pushed a commit
that referenced
this pull request
Mar 13, 2019
* 2-0-stable: (43 commits) remove path that i copied from my personal computer Auto merge of #6586 - bundler:segiddins/softer-major-deprecations, r=indirect Merge #6941 Merge #6834 Version 2.0.1 with changelog update tested rubygems in travis Lower required RubyGems to 2.5 or greater Bundler 2.0 with changelog update CHANGELOG with new changes and release Merge #6856 add RubyGems v3.0.1 to rg clone task Version 2.0.0.pre.3 wih changelog update tested versions of RubyGems in travis update gemspec to require RubyGems 3.0.0 Merge #6849 Merge #6853 Revert "Version 2.0.0 with changelog" Version 2.0.0 with changelog fix breaking edge case spec Merge #6818 ... (cherry picked from commit 77f4c15)
deivid-rodriguez
pushed a commit
that referenced
this pull request
Mar 13, 2019
* 2-0-stable: (43 commits) remove path that i copied from my personal computer Auto merge of #6586 - bundler:segiddins/softer-major-deprecations, r=indirect Merge #6941 Merge #6834 Version 2.0.1 with changelog update tested rubygems in travis Lower required RubyGems to 2.5 or greater Bundler 2.0 with changelog update CHANGELOG with new changes and release Merge #6856 add RubyGems v3.0.1 to rg clone task Version 2.0.0.pre.3 wih changelog update tested versions of RubyGems in travis update gemspec to require RubyGems 3.0.0 Merge #6849 Merge #6853 Revert "Version 2.0.0 with changelog" Version 2.0.0 with changelog fix breaking edge case spec Merge #6818 ... (cherry picked from commit 77f4c15)
deivid-rodriguez
pushed a commit
that referenced
this pull request
Mar 15, 2019
* 2-0-stable: (43 commits) remove path that i copied from my personal computer Auto merge of #6586 - bundler:segiddins/softer-major-deprecations, r=indirect Merge #6941 Merge #6834 Version 2.0.1 with changelog update tested rubygems in travis Lower required RubyGems to 2.5 or greater Bundler 2.0 with changelog update CHANGELOG with new changes and release Merge #6856 add RubyGems v3.0.1 to rg clone task Version 2.0.0.pre.3 wih changelog update tested versions of RubyGems in travis update gemspec to require RubyGems 3.0.0 Merge #6849 Merge #6853 Revert "Version 2.0.0 with changelog" Version 2.0.0 with changelog fix breaking edge case spec Merge #6818 ... (cherry picked from commit 77f4c15)
deivid-rodriguez
pushed a commit
that referenced
this pull request
Mar 20, 2019
* 2-0-stable: (43 commits) remove path that i copied from my personal computer Auto merge of #6586 - bundler:segiddins/softer-major-deprecations, r=indirect Merge #6941 Merge #6834 Version 2.0.1 with changelog update tested rubygems in travis Lower required RubyGems to 2.5 or greater Bundler 2.0 with changelog update CHANGELOG with new changes and release Merge #6856 add RubyGems v3.0.1 to rg clone task Version 2.0.0.pre.3 wih changelog update tested versions of RubyGems in travis update gemspec to require RubyGems 3.0.0 Merge #6849 Merge #6853 Revert "Version 2.0.0 with changelog" Version 2.0.0 with changelog fix breaking edge case spec Merge #6818 ... (cherry picked from commit 77f4c15)
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is your fix for the problem, implemented in this PR?
These changes enabled to use the same configuration of executables in ruby core repository.
Why did you choose this fix out of the possible options?
The ruby core repository uses
exedirectory for other usage. I choselibexecinstead ofexein ruby core. And, The location ofbundler.gemspecis not the root of the repository on ruby core. We should restorelibexectoexeunder thelibdir.see. https://github.com/ruby/ruby/blob/trunk/lib/bundler.gemspec