Skip to content
This repository has been archived by the owner on Apr 14, 2021. It is now read-only.

Allow files other than Gemfile.lock to be opened in definition specs #6834

Merged
1 commit merged into from
Dec 9, 2018
Merged

Allow files other than Gemfile.lock to be opened in definition specs #6834

1 commit merged into from
Dec 9, 2018

Conversation

segiddins
Copy link
Member

What was the end-user problem that led to this PR?

The problem was the specs are brittle.

What was your diagnosis of the problem?

My diagnosis was we should assume code can open other files.

What is your fix for the problem, implemented in this PR?

My fix allows other files to be opened, and only raises when opening the file under test.

hsbt
hsbt approved these changes Dec 9, 2018
View reviewed changes
Copy link
Member

@hsbt hsbt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It makes rspec example portable.

@hsbt
Copy link
Member

hsbt commented Dec 9, 2018

@bundlerbot r+

ghost pushed a commit that referenced this pull request Dec 9, 2018
@bundlerbot @segiddins
Merge #6834
cca1f63 
6834: Allow files other than Gemfile.lock to be opened in definition specs r=hsbt a=segiddins

### What was the end-user problem that led to this PR?

The problem was the specs are brittle.

### What was your diagnosis of the problem?

My diagnosis was  we should assume code can open other files.

### What is your fix for the problem, implemented in this PR?

My fix allows other files to be opened, and only raises when opening the file under test.

Co-authored-by: Samuel Giddins <segiddins@segiddins.me>
@ghost
Copy link

ghost commented Dec 9, 2018

Build succeeded

@ghost ghost merged commit 9b843ed into master Dec 9, 2018
@ghost ghost deleted the segiddins/allow-rubygems-to-open-files branch December 9, 2018 23:18
hsbt pushed a commit that referenced this pull request Dec 10, 2018
@bundlerbot @hsbt
Merge #6834
5fb389d 
6834: Allow files other than Gemfile.lock to be opened in definition specs r=hsbt a=segiddins

### What was the end-user problem that led to this PR?

The problem was the specs are brittle.

### What was your diagnosis of the problem?

My diagnosis was  we should assume code can open other files.

### What is your fix for the problem, implemented in this PR?

My fix allows other files to be opened, and only raises when opening the file under test.

Co-authored-by: Samuel Giddins <segiddins@segiddins.me>
(cherry picked from commit cca1f63)
@hsbt hsbt added this to the 2.0.0 milestone Dec 10, 2018
@hsbt
Copy link
Member

hsbt commented Dec 10, 2018

@colby-swandale Can you backport this into 2-0-stable branch? This needs to be rubygems change that is https://github.com/rubygems/rubygems/blob/master/lib/rubygems/stub_specification.rb#L114

colby-swandale added a commit that referenced this pull request Dec 11, 2018
@colby-swandale
Merge branch '1-17-stable'
a845a0d 
* 1-17-stable:
  Version 1.17.2 with changelog
  Merge #6798
  Merge #6818
  Merge #6786
  Merge #6743
  Merge #6742
  Merge #6740
  Merge #6834
  Merge pull request #6752 from bundler/indirect/backport-6737
hsbt pushed a commit that referenced this pull request Jan 4, 2019
@bundlerbot @hsbt
Merge #6834
28e346e 
6834: Allow files other than Gemfile.lock to be opened in definition specs r=hsbt a=segiddins

### What was the end-user problem that led to this PR?

The problem was the specs are brittle.

### What was your diagnosis of the problem?

My diagnosis was  we should assume code can open other files.

### What is your fix for the problem, implemented in this PR?

My fix allows other files to be opened, and only raises when opening the file under test.

Co-authored-by: Samuel Giddins <segiddins@segiddins.me>
(cherry picked from commit cca1f63)
hsbt added a commit that referenced this pull request Jan 4, 2019
@hsbt
Merge pull request #6873 from bundler/pick-missing-commits-for-2-0
c627124 
Merge #6834 for 2-0-stable
colby-swandale added a commit that referenced this pull request Feb 10, 2019
@colby-swandale
Merge branch '2-0-stable'
ccca7a6 
* 2-0-stable: (43 commits)
  remove path that i copied from my personal computer
  Auto merge of #6586 - bundler:segiddins/softer-major-deprecations, r=indirect
  Merge #6941
  Merge #6834
  Version 2.0.1 with changelog
  update tested rubygems in travis
  Lower required RubyGems to 2.5 or greater
  Bundler 2.0 with changelog
  update CHANGELOG with new changes and release
  Merge #6856
  add RubyGems v3.0.1 to rg clone task
  Version 2.0.0.pre.3 wih changelog
  update tested versions of RubyGems in travis
  update gemspec to require RubyGems 3.0.0
  Merge #6849
  Merge #6853
  Revert "Version 2.0.0 with changelog"
  Version 2.0.0 with changelog
  fix breaking edge case spec
  Merge #6818
  ...
colby-swandale added a commit that referenced this pull request Feb 12, 2019
@colby-swandale
Merge branch '2-0-stable'
77f4c15 
* 2-0-stable: (43 commits)
  remove path that i copied from my personal computer
  Auto merge of #6586 - bundler:segiddins/softer-major-deprecations, r=indirect
  Merge #6941
  Merge #6834
  Version 2.0.1 with changelog
  update tested rubygems in travis
  Lower required RubyGems to 2.5 or greater
  Bundler 2.0 with changelog
  update CHANGELOG with new changes and release
  Merge #6856
  add RubyGems v3.0.1 to rg clone task
  Version 2.0.0.pre.3 wih changelog
  update tested versions of RubyGems in travis
  update gemspec to require RubyGems 3.0.0
  Merge #6849
  Merge #6853
  Revert "Version 2.0.0 with changelog"
  Version 2.0.0 with changelog
  fix breaking edge case spec
  Merge #6818
  ...
colby-swandale added a commit that referenced this pull request Feb 18, 2019
@colby-swandale
1
c348978 
* commit '77f4c15451aaac135d19ac5d1637981d7b05d799': (43 commits)
  remove path that i copied from my personal computer
  Auto merge of #6586 - bundler:segiddins/softer-major-deprecations, r=indirect
  Merge #6941
  Merge #6834
  Version 2.0.1 with changelog
  update tested rubygems in travis
  Lower required RubyGems to 2.5 or greater
  Bundler 2.0 with changelog
  update CHANGELOG with new changes and release
  Merge #6856
  add RubyGems v3.0.1 to rg clone task
  Version 2.0.0.pre.3 wih changelog
  update tested versions of RubyGems in travis
  update gemspec to require RubyGems 3.0.0
  Merge #6849
  Merge #6853
  Revert "Version 2.0.0 with changelog"
  Version 2.0.0 with changelog
  fix breaking edge case spec
  Merge #6818
  ...
colby-swandale added a commit that referenced this pull request Feb 20, 2019
@colby-swandale
Merge branch '2-0-stable'
dcd92c7 
* 2-0-stable: (43 commits)
  remove path that i copied from my personal computer
  Auto merge of #6586 - bundler:segiddins/softer-major-deprecations, r=indirect
  Merge #6941
  Merge #6834
  Version 2.0.1 with changelog
  update tested rubygems in travis
  Lower required RubyGems to 2.5 or greater
  Bundler 2.0 with changelog
  update CHANGELOG with new changes and release
  Merge #6856
  add RubyGems v3.0.1 to rg clone task
  Version 2.0.0.pre.3 wih changelog
  update tested versions of RubyGems in travis
  update gemspec to require RubyGems 3.0.0
  Merge #6849
  Merge #6853
  Revert "Version 2.0.0 with changelog"
  Version 2.0.0 with changelog
  fix breaking edge case spec
  Merge #6818
  ...

(cherry picked from commit 77f4c15)
deivid-rodriguez pushed a commit that referenced this pull request Feb 28, 2019
@colby-swandale @deivid-rodriguez
Merge branch '2-0-stable'
ee02a03 
* 2-0-stable: (43 commits)
  remove path that i copied from my personal computer
  Auto merge of #6586 - bundler:segiddins/softer-major-deprecations, r=indirect
  Merge #6941
  Merge #6834
  Version 2.0.1 with changelog
  update tested rubygems in travis
  Lower required RubyGems to 2.5 or greater
  Bundler 2.0 with changelog
  update CHANGELOG with new changes and release
  Merge #6856
  add RubyGems v3.0.1 to rg clone task
  Version 2.0.0.pre.3 wih changelog
  update tested versions of RubyGems in travis
  update gemspec to require RubyGems 3.0.0
  Merge #6849
  Merge #6853
  Revert "Version 2.0.0 with changelog"
  Version 2.0.0 with changelog
  fix breaking edge case spec
  Merge #6818
  ...

(cherry picked from commit 77f4c15)
deivid-rodriguez pushed a commit that referenced this pull request Mar 13, 2019
@colby-swandale @deivid-rodriguez
Merge branch '2-0-stable'
4b7a654 
* 2-0-stable: (43 commits)
  remove path that i copied from my personal computer
  Auto merge of #6586 - bundler:segiddins/softer-major-deprecations, r=indirect
  Merge #6941
  Merge #6834
  Version 2.0.1 with changelog
  update tested rubygems in travis
  Lower required RubyGems to 2.5 or greater
  Bundler 2.0 with changelog
  update CHANGELOG with new changes and release
  Merge #6856
  add RubyGems v3.0.1 to rg clone task
  Version 2.0.0.pre.3 wih changelog
  update tested versions of RubyGems in travis
  update gemspec to require RubyGems 3.0.0
  Merge #6849
  Merge #6853
  Revert "Version 2.0.0 with changelog"
  Version 2.0.0 with changelog
  fix breaking edge case spec
  Merge #6818
  ...

(cherry picked from commit 77f4c15)
deivid-rodriguez pushed a commit that referenced this pull request Mar 13, 2019
@colby-swandale @deivid-rodriguez
Merge branch '2-0-stable'
b1d2b48 
* 2-0-stable: (43 commits)
  remove path that i copied from my personal computer
  Auto merge of #6586 - bundler:segiddins/softer-major-deprecations, r=indirect
  Merge #6941
  Merge #6834
  Version 2.0.1 with changelog
  update tested rubygems in travis
  Lower required RubyGems to 2.5 or greater
  Bundler 2.0 with changelog
  update CHANGELOG with new changes and release
  Merge #6856
  add RubyGems v3.0.1 to rg clone task
  Version 2.0.0.pre.3 wih changelog
  update tested versions of RubyGems in travis
  update gemspec to require RubyGems 3.0.0
  Merge #6849
  Merge #6853
  Revert "Version 2.0.0 with changelog"
  Version 2.0.0 with changelog
  fix breaking edge case spec
  Merge #6818
  ...

(cherry picked from commit 77f4c15)
deivid-rodriguez pushed a commit that referenced this pull request Mar 15, 2019
@colby-swandale @deivid-rodriguez
Merge branch '2-0-stable'
e6d4f41 
* 2-0-stable: (43 commits)
  remove path that i copied from my personal computer
  Auto merge of #6586 - bundler:segiddins/softer-major-deprecations, r=indirect
  Merge #6941
  Merge #6834
  Version 2.0.1 with changelog
  update tested rubygems in travis
  Lower required RubyGems to 2.5 or greater
  Bundler 2.0 with changelog
  update CHANGELOG with new changes and release
  Merge #6856
  add RubyGems v3.0.1 to rg clone task
  Version 2.0.0.pre.3 wih changelog
  update tested versions of RubyGems in travis
  update gemspec to require RubyGems 3.0.0
  Merge #6849
  Merge #6853
  Revert "Version 2.0.0 with changelog"
  Version 2.0.0 with changelog
  fix breaking edge case spec
  Merge #6818
  ...

(cherry picked from commit 77f4c15)
deivid-rodriguez pushed a commit that referenced this pull request Mar 20, 2019
@colby-swandale @deivid-rodriguez
Merge branch '2-0-stable'
e590c0f 
* 2-0-stable: (43 commits)
  remove path that i copied from my personal computer
  Auto merge of #6586 - bundler:segiddins/softer-major-deprecations, r=indirect
  Merge #6941
  Merge #6834
  Version 2.0.1 with changelog
  update tested rubygems in travis
  Lower required RubyGems to 2.5 or greater
  Bundler 2.0 with changelog
  update CHANGELOG with new changes and release
  Merge #6856
  add RubyGems v3.0.1 to rg clone task
  Version 2.0.0.pre.3 wih changelog
  update tested versions of RubyGems in travis
  update gemspec to require RubyGems 3.0.0
  Merge #6849
  Merge #6853
  Revert "Version 2.0.0 with changelog"
  Version 2.0.0 with changelog
  fix breaking edge case spec
  Merge #6818
  ...

(cherry picked from commit 77f4c15)
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hsbt hsbt hsbt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@segiddins @hsbt