This repository has been archived by the owner on Apr 14, 2021. It is now read-only.
Remove global_path_appends_ruby_scope setting
#7163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a bug fix, so it makes no sense to make it configurable. Also, the fix is unlikely to cause problems other than maybe needing a fresh `bundle install` on some edge cases. So, let's ship the fix and remove the setting.
|
Hopefully nothing is depending on the buggy behavior here 😅 @bundlerbot r+ |
ghost
pushed a commit
that referenced
this pull request
May 23, 2019
7163: Remove `global_path_appends_ruby_scope` setting r=indirect a=deivid-rodriguez ### What was the end-user problem that led to this PR? The problem was we're artificially holding shipping bug fixes like the fact the ruby scope is not included in the install path when `BUNDLE_PATH` is used as an environment variable or global setting. ### What was your diagnosis of the problem? My diagnosis was that we can remove the setting, and that it's fine that affected users rerun `bundle install` to get their installation paths fixed. ### What is your fix for the problem, implemented in this PR? My fix is to remove the setting. Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net>
Build succeeded |
ghost
merged commit 
|
Yeah, me too 😃. Thanks @indirect! |
This was referenced Dec 17, 2019
Closed
ghost
pushed a commit
that referenced
this pull request
Dec 17, 2019
7501: Delay appending `ruby/<ABI_VERSION>` to `$BUNDLE_PATH` r=indirect a=deivid-rodriguez ### What was the end-user problem that led to this PR? The problem was that #7163 broke several things regarding official docker ruby images. ### What was your diagnosis of the problem? My diagnosis was that appending `ruby/<ABI_VERSION>` to `$BUNDLE_PATH` break things there because gems nor executables are no longer installed at a location that `rubygems` now about. ### What is your fix for the problem, implemented in this PR? My fix is to revert the offending PR for the time being. ### Why did you choose this fix out of the possible options? I chose this fix because it's quick. I think the better fix would be to get `BUNDLE_PATH__SYSTEM=true` working as expected and upstream that change to the docker images, because I think that's exactly the use case for the docker images. But I need more time for that, and I want to restore working behavior. /cc @indirect Sorry, you were right about this being dangerous 😳 Closes #7197. Closes #7494. Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net>
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user problem that led to this PR?
The problem was we're artificially holding shipping bug fixes like the fact the ruby scope is not included in the install path when
BUNDLE_PATHis used as an environment variable or global setting.What was your diagnosis of the problem?
My diagnosis was that we can remove the setting, and that it's fine that affected users rerun
bundle installto get their installation paths fixed.What is your fix for the problem, implemented in this PR?
My fix is to remove the setting.