This repository has been archived by the owner on Apr 14, 2021. It is now read-only.
Revert "Migrate requires from exe/ to also be relative" #7216
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user problem that led to this PR?
The problem was that in #7193, I included a commit to migrate requires included in bundler's executable to use
require_relative
. That broke stuff.What was your diagnosis of the problem?
My diagnosis was the assumption that if
<install_folder>/exe/bundle
lives on a folder, the corresponding bundler lib lives on<install_folder>/lib
doesn't hold for default gems. Default gems for gems with executables live insite_lib
but install their executables in the standard gem location. That means that the reference commit breaks bundler when it is installed as a default gem.What is your fix for the problem, implemented in this PR?
My fix is to revert the commit.
Why did you choose this fix out of the possible options?
I chose this fix because it's the easiest way. The proper long term fix is probably to make default gems behave in a more standard way. There's some ongoing work on that here: rubygems/rubygems#2166.