Skip to content
This repository has been archived by the owner on Apr 14, 2021. It is now read-only.

Support multiple groups for --without-group and --only-group options … #7404

Merged
1 commit merged into from Nov 4, 2019
Merged

Support multiple groups for --without-group and --only-group options … #7404

1 commit merged into from Nov 4, 2019

Conversation

fatkodima
Copy link
Contributor

This is a reworked version of #6939
It accepts multiple groups for --without-group and --only-group.

Closes #6939

deivid-rodriguez
deivid-rodriguez suggested changes Oct 31, 2019
View reviewed changes
Copy link
Member

@deivid-rodriguez deivid-rodriguez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Can you update the docs bundle-list.ronn as well to mention this? You can use the --with and --without options in bundle-install.ronn as a reference.

@deivid-rodriguez deivid-rodriguez mentioned this pull request Oct 31, 2019
Closed
@fatkodima
Copy link
Contributor Author

@deivid-rodriguez Updated with documentation.

@fatkodima fatkodima force-pushed the cli-list-multiple-groups branch 2 times, most recently from 1abc30c to 8b812da Compare October 31, 2019 18:26
deivid-rodriguez
deivid-rodriguez reviewed Nov 1, 2019
View reviewed changes
Copy link
Member

@deivid-rodriguez deivid-rodriguez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a really minor comment on the docs.

man/bundle-list.1.txt Outdated Show resolved Hide resolved
man/bundle-list.1.txt Outdated Show resolved Hide resolved
@fatkodima
Copy link
Contributor Author

@deivid-rodriguez Updated.

@fatkodima fatkodima force-pushed the cli-list-multiple-groups branch 2 times, most recently from 9bc346f to 5d063a0 Compare November 1, 2019 11:22
deivid-rodriguez
deivid-rodriguez approved these changes Nov 4, 2019
View reviewed changes
Copy link
Member

@deivid-rodriguez deivid-rodriguez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me!

@deivid-rodriguez
Copy link
Member

@bundlerbot merge

ghost pushed a commit that referenced this pull request Nov 4, 2019
@bundlerbot @fatkodima
Merge #7404
3aa0391 
7404: Support multiple groups for --without-group and --only-group options … r=deivid-rodriguez a=fatkodima

This is a reworked version of #6939 
It accepts multiple groups for `--without-group` and `--only-group`.

Closes #6939 

Co-authored-by: fatkodima <fatkodima123@gmail.com>
@ghost
Copy link

ghost commented Nov 4, 2019

Build succeeded

@ghost ghost merged commit 95d7e47 into rubygems:master Nov 4, 2019
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@deivid-rodriguez deivid-rodriguez deivid-rodriguez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fatkodima @deivid-rodriguez