This repository has been archived by the owner on Apr 14, 2021. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 2k
Support multiple groups for --without-group and --only-group options … #7404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deivid-rodriguez
suggested changes
Oct 31, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Can you update the docs bundle-list.ronn
as well to mention this? You can use the --with
and --without
options in bundle-install.ronn
as a reference.
fatkodima
force-pushed
the
cli-list-multiple-groups
branch
from
October 31, 2019 17:44
cee187f
to
251af98
Compare
@deivid-rodriguez Updated with documentation. |
fatkodima
force-pushed
the
cli-list-multiple-groups
branch
2 times, most recently
from
October 31, 2019 18:26
1abc30c
to
8b812da
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a really minor comment on the docs.
fatkodima
force-pushed
the
cli-list-multiple-groups
branch
from
November 1, 2019 11:14
8b812da
to
3b525ee
Compare
@deivid-rodriguez Updated. |
fatkodima
force-pushed
the
cli-list-multiple-groups
branch
2 times, most recently
from
November 1, 2019 11:22
9bc346f
to
5d063a0
Compare
…in bundler list command
fatkodima
force-pushed
the
cli-list-multiple-groups
branch
from
November 1, 2019 13:56
5d063a0
to
95d7e47
Compare
deivid-rodriguez
approved these changes
Nov 4, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me!
@bundlerbot merge |
ghost
pushed a commit
that referenced
this pull request
Nov 4, 2019
Build succeeded |
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a reworked version of #6939
It accepts multiple groups for
--without-group
and--only-group
.Closes #6939