Multiple without-group support for bundler list #6939
Conversation
|
Thanks for opening a pull request and helping make Bundler better! Someone from the Bundler team will take a look at your pull request shortly and leave any feedback. Please make sure that your pull request has tests for any changes or added functionality. We use Travis CI to test and make sure your change works functionally and uses acceptable conventions, you can review the current progress of Travis CI in the PR status window below. If you have any questions or concerns that you wish to ask, feel free to leave a comment in this PR or join our #bundler channel on Slack. For more information about contributing to the Bundler project feel free to review our CONTRIBUTING guide |
| @@ -314,7 +314,7 @@ def show(gem_name = nil) | |||
| desc "list", "List all gems in the bundle" | |||
| method_option "name-only", :type => :boolean, :banner => "print only the gem names" | |||
| method_option "only-group", :type => :string, :banner => "print gems from a particular group" | |||
| method_option "without-group", :type => :string, :banner => "print all gems expect from a group" | |||
| method_option "without-group", :type => :string, :banner => "print all gems expect from 1 or multiple groups" | |||
There was a problem hiding this comment.
how does a given set of groups sound instead?
| elsif @options["only-group"] | ||
| groups.select {|g| g == @options["only-group"].to_sym } | ||
| else | ||
| groups | ||
| end.map(&:to_sym) | ||
|
|
There was a problem hiding this comment.
Please don't remove the spacing. It helps with readability.
| @@ -45,13 +53,14 @@ def filtered_specs_by_groups | |||
|
|
|||
| show_groups = | |||
| if @options["without-group"] | |||
| groups.reject {|g| g == @options["without-group"].to_sym } | |||
| without_groups.inject(groups) do |memo, without_group| | |||
There was a problem hiding this comment.
I'm not sure what memo means here, can you clarify please?
|
@denispasin hi, are you still interested in this PR? There are pending review questions. If we don’t get an update we may have to close it. Thanks. |
|
Closing in favor of #7404. Thanks for starting this! |
What was the end-user problem that led to this PR?
The problem was that I needed to list all gems and dependencies that weren't in group :development or :test (or both of the together) but
bundler list --without-groupwas only accepting one group at a time.What was your diagnosis of the problem?
My diagnosis was I should just make it work for multiple groups
What is your fix for the problem, implemented in this PR?
My fix is I split groups by
,in args.Why did you choose this fix out of the possible options?
I chose this fix because it's simple and look like you can find in other cli.
I have two questions: Should I take care of the case where you have multiple
--without-groupspecified ? Should I support--without-groups?