Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reinstate nonfunctional --no-daemonize, --daemonize options that warn #381

Conversation

olleolleolle
Copy link
Member

Description:

Reinstate a --daemonize and --no-daemonize which only warn.

Follow-up to #378 and fixes the problem in #380.

Tasks:

  • Describe the problem / feature
  • Write tests

I will abide by the code of conduct.

@olleolleolle olleolleolle force-pushed the reinstate-a-nonfunctional-no-daemonize-option branch from 2bfca05 to 173a27a Compare October 12, 2023 11:18
@olleolleolle olleolleolle marked this pull request as ready for review October 12, 2023 11:19
@olleolleolle olleolleolle changed the title Reinstate a nonfunctional no daemonize option Reinstate nonfunctional --no-daemonize, --daemonize options that warn Oct 12, 2023
@olleolleolle
Copy link
Member Author

See ruby/psych#655 for the reason why JRuby fails its build.

@olleolleolle olleolleolle merged commit 64c73f3 into rubygems:main Oct 12, 2023
5 of 6 checks passed
@olleolleolle
Copy link
Member Author

olleolleolle commented Oct 16, 2023

As a follow-up, I have now released gemstash-2.7.1-java.gem, too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants