Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flash banners persist too long #3149

Closed
kevinlinxc opened this issue Jul 15, 2022 · 0 comments · Fixed by #3198
Closed

Flash banners persist too long #3149

kevinlinxc opened this issue Jul 15, 2022 · 0 comments · Fixed by #3198
Labels

Comments

@kevinlinxc
Copy link
Contributor

Steps to Reproduce

  1. Sign in to Rubygems.org
  2. Go to settings -> api keys
  3. Enter the wrong password when prompted to verify with your password - this will bring up a banner/flash message
  4. Enter the right password

Expected Behavior

You arrive on the API keys page without a banner saying you put in the wrong password

Current Behavior

You arrive on the API keys page with the banner persisting

I think the problem might be in many locations on the site, but this is the one I ran into just now.

Possible Solution

Clearing all banners might work? Other pages will want to let through some banners though, so maybe clearing errors if the cause of the error is gone. It could be pretty straightforward to clear error banners if the user logs in successfully.

Environment

Browser and its version: Chrome 103

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant