Fixes flash banners persisting for too long

[americodls]

Fixes #3149

[americodls]

Even though the issue has been created for another workflow, but this problem happens where the verify step is invoked. I've chosen this test file because the context was easier to it (I guess).

Happy to change anything if is needed.

I also have found other parts of the application where the same problem would occur.
I would be happy to fix all of them in other PR applying the test guidance I get in this PR.

[simi]

@americodls can you please fix Rubocop violation at https://github.com/rubygems/rubygems.org/runs/8053686977?check_suite_focus=true?

[codecov]

Codecov Report

Merging #3198 (bb4d485) into master (dee7118) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #3198   +/-   ##
=======================================
  Coverage   98.18%   98.18%           
=======================================
  Files         110      110           
  Lines        3310     3310           
=======================================
  Hits         3250     3250           
  Misses         60       60           

Impacted Files	Coverage Δ
app/controllers/sessions_controller.rb	100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[americodls]

@americodls can you please fix Rubocop violation at https://github.com/rubygems/rubygems.org/runs/8053686977?check_suite_focus=true?

Done!

[simi]

Thanks @americodls. Feel free to submit PR fixing more cases. If I understand it well (per https://guides.rubyonrails.org/action_controller_overview.html#flash-now), flash.now should be used if followed by render. Sadly there is no rubocop-rails rule for this.

[americodls]

@simi I am gonna try to create a custom cop to enforce flash.now before render.
That will help me to find and fix all the other occurrences on this project.
Thanks for the feedback here!

[simi]

@americodls that was just an idea, I have no idea if that's actually good idea. :)