Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump rubocop-rails from 2.15.2 to 2.16.0 and fix issues #3207

Merged

Conversation

americodls
Copy link
Contributor

This new version of rubocop-rails contains a new cop (Rails/ActionControllerFlashBeforeRender) that will detect and fix a well-known bug as this example

This PR bumps the rubocop-rails version and fixes the other occurrences of that bug.

@codecov
Copy link

codecov bot commented Sep 9, 2022

Codecov Report

Merging #3207 (4ed828c) into master (3cc8bb1) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #3207   +/-   ##
=======================================
  Coverage   98.40%   98.40%           
=======================================
  Files         110      110           
  Lines        3320     3320           
=======================================
  Hits         3267     3267           
  Misses         53       53           
Impacted Files Coverage Δ
app/controllers/api_keys_controller.rb 98.27% <100.00%> (ø)
app/controllers/multifactor_auths_controller.rb 100.00% <100.00%> (ø)
app/controllers/owners_controller.rb 98.03% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@simi
Copy link
Member

simi commented Sep 10, 2022

Thanks for the PR! Nice job on upstreaming the before render cop 💪.

Some of the problems are already addressed at #3204. Let's wait until that is merged and we will see how much is going to left. 🙏

@simi
Copy link
Member

simi commented Sep 12, 2022

@americodls would you mind to rebase now please?

@americodls americodls force-pushed the upgrade-rubocop-rails-and-fix-issues branch from 9d4da25 to 5bcca4f Compare September 12, 2022 21:35
@simi
Copy link
Member

simi commented Sep 12, 2022

Hmm 🤔, I still see still some unrelated changes. Would it be possible to just update rubocop-rails to 2.16.0 and fix Rails/ActionControllerFlashBeforeRender violations?

@americodls americodls force-pushed the upgrade-rubocop-rails-and-fix-issues branch from 5bcca4f to 4ed828c Compare September 12, 2022 21:58
@americodls americodls changed the title Upgrade rubocop rails and fix issues Bump rubocop-rails from 2.15.2 to 2.16.0 and fix issues Sep 12, 2022
@simi simi merged commit 5b434b6 into rubygems:master Sep 12, 2022
@simi
Copy link
Member

simi commented Sep 12, 2022

Amazing @americodls! Thanks for your patience.

@rubygems-org-shipit rubygems-org-shipit bot temporarily deployed to staging September 12, 2022 22:18 Inactive
@rubygems-org-shipit rubygems-org-shipit bot temporarily deployed to production September 13, 2022 15:34 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants